Skip to content

DOC: update ohlc docstring so that it reflects the real use #31919 #31941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2020
Merged

DOC: update ohlc docstring so that it reflects the real use #31919 #31941

merged 2 commits into from
Feb 15, 2020

Conversation

dequadras
Copy link
Contributor

@dequadras dequadras commented Feb 13, 2020

The test python scripts/validate_docstrings.py pandas.core.groupby.GroupBy.ohlc returns errors, but that is something that happens with many functions at the moment

################# Docstring (pandas.core.groupby.GroupBy.ohlc) #################
################################################################################

Compute open, high, low and close values of a group, excluding missing values.

For multiple groupings, the result index will be a MultiIndex

Returns
-------
DataFrame
    Open, high, low and close values within each group.

See Also
--------
Series.groupby
DataFrame.groupby

################################################################################
################################## Validation ##################################
################################################################################

3 Errors found:
	Missing description for See Also "Series.groupby" reference
	Missing description for See Also "DataFrame.groupby" reference
	No examples section found```

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dequadras - the errors seem unrelated

@MarcoGorelli
Copy link
Member

but that is something that happens with many functions at the moment

Yes, the CI check ignores certain errors:

### DOCSTRINGS ###
if [[ -z "$CHECK" || "$CHECK" == "docstrings" ]]; then

    MSG='Validate docstrings (GL03, GL04, GL05, GL06, GL07, GL09, GL10, SS04, SS05, PR03, PR04, PR05, PR10, EX04, RT01, RT04, RT05, SA02, SA03, SA05)' ; echo $MSG
    $BASE_DIR/scripts/validate_docstrings.py --format=actions --errors=GL03,GL04,GL05,GL06,GL07,GL09,GL10,SS04,SS05,PR03,PR04,PR05,PR10,EX04,RT01,RT04,RT05,SA02,SA03,SA05
    RET=$(($RET + $?)) ; echo $MSG "DONE"

fi

@WillAyd
Copy link
Member

WillAyd commented Feb 14, 2020

Can you merge master?

@dequadras
Copy link
Contributor Author

Can you merge master?

I don't have write access

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Feb 14, 2020

Can you merge master?

I don't have write access

I think Will was suggesting that you merge them locally and push another commit:

git fetch upstream master
git merge upstream/master
git push origin ohlc-docstring-update

EDIT

There aren't any conflicts with master - @WillAyd was the purpose of the merge just to restart the CI process?

@dequadras
Copy link
Contributor Author

Can you merge master?

Done

@WillAyd WillAyd added this to the 1.1 milestone Feb 15, 2020
@WillAyd WillAyd merged commit 2aa9cb9 into pandas-dev:master Feb 15, 2020
@WillAyd
Copy link
Member

WillAyd commented Feb 15, 2020

Thanks @dequadras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ohlc documentation
5 participants