CLN: ASV indexing #19031
Merged
CLN: ASV indexing #19031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are the asv for the benchmarks that were moved: |
|
@mroeschke : Looks like some lint errors, but otherwise, Travis is happy. |
jreback
requested changes
Jan 2, 2018
asv_bench/benchmarks/index_object.py
Outdated
| [np.arange(1000), np.arange(20), list(string.ascii_letters)], | ||
| names=['one', 'two', 'three']) | ||
| self.mi_med = MultiIndex.from_product( | ||
| [np.arange(1000), np.arange(10), list('A')], |
There was a problem hiding this comment.
I think we should make a sub-dir scheme here
IOW
benchmarks/index/.....
and split out multi, numeric, datetime...etc
jreback
added
Benchmark
mroeschke
force-pushed
the
asv_clean_indexing
branch
from
07f2259 to
361a91b
Compare
Codecov Report
@@ Coverage Diff @@
## master #19031 +/- ##
==========================================
- Coverage 91.57% 91.56% -0.01%
==========================================
Files 150 150
Lines 48942 48942
==========================================
- Hits 44818 44816 -2
- Misses 4124 4126 +2
Continue to review full report at Codecov.
|
|
@jreback Some of the benchmarks in the file param'd over the various types of indexes or combined different indexes in the setup which would be difficult to split. Instead, I put the MultiIndex benchmarks in their own file. |
jreback
approved these changes
Jan 3, 2018
|
thanks @mroeschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved some benchmarks to
index_object.pythat were testing method of (mostly) MultiIndexes. Otherwise mostly cleanup and now linting files that start with i.