Collect tslibs test, organize PeriodIndex tests #19627
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
reviewed
Feb 10, 2018
| @@ -933,3 +935,16 @@ def test_datetime64_with_DateOffset(klass, assert_func): | |||
| Timestamp('2000-02-29', tz='US/Central')], name='a') | |||
| assert_func(result, exp) | |||
| assert_func(result2, exp) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize('years,months', product([-1, 0, 1], [-2, 0, 2])) | |||
There was a problem hiding this comment.
If you parametrize years & months separately, pytest will handle the product
i.e. @pytest.mark.parametrize(('years',[-1, 0, 1]), ('months', [-2, 0, 2]))
jreback
requested changes
Feb 10, 2018
| @@ -138,6 +138,48 @@ def test_astype_object(self): | |||
| tm.assert_index_equal(casted, Index(exp_values, dtype=np.object_)) | |||
| assert casted.tolist() == exp_values | |||
|
|
|||
| idx = pd.date_range(start='2013-01-01', periods=4, freq='M', | |||
There was a problem hiding this comment.
can you avoid duplication of lots of code and just parameterize over the tz.
|
|
||
|
|
||
| def test_to_datetime1(): | ||
| actual = pd.to_datetime(datetime(2008, 1, 15)) |
There was a problem hiding this comment.
can you add a refernce for this test (e.g. what is it testing)
can you put it near other tests that are similar
| @@ -250,6 +250,79 @@ def test_sub_isub(self): | |||
| rng -= 1 | |||
| tm.assert_index_equal(rng, expected) | |||
|
|
|||
| # ------------------------------------------------------------------ | |||
| # PeriodIndex.shift is used by __add__ and __sub__ | |||
|
|
||
| assert period_asfreq(1, get_freq('U'), get_freq('N'), False) == 1000 | ||
|
|
||
| def test_period_ordinal_start_values(self): |
|
|
||
| def test_period_ordinal_start_values(self): | ||
| # information for 1.1.1970 | ||
| assert period_ordinal(1970, 1, 1, 0, 0, 0, 0, 0, get_freq('A')) == 0 |
|
|
||
| def test_period_ordinal_week(self): | ||
| assert period_ordinal(1970, 1, 4, 0, 0, 0, 0, 0, get_freq('W')) == 1 | ||
| assert period_ordinal(1970, 1, 5, 0, 0, 0, 0, 0, get_freq('W')) == 2 |
| assert (result == datetime(2012, 9, 7)) | ||
|
|
||
|
|
||
| class TestParseISO8601(object): |
There was a problem hiding this comment.
these are conversion tests no? (so separate file). I don't really want much in tslib/test_testlib.py except if it doesnt' fit anywhere else
|
see comments above |
|
@maxim-lian good catch; I'll do that in the next draft. |
This was referenced Feb 10, 2018
jreback
pushed a commit
that referenced
this pull request
Feb 11, 2018
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parametrize a bunch of nested tests.