test_astype portion of #19627 #19637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Feb 10, 2018
| result = idx.astype(object) | ||
| assert isinstance(result, Index) | ||
| assert result.dtype == object | ||
| tm.assert_index_equal(result, expected) |
There was a problem hiding this comment.
we don’t need all of these other comparisons as the assert_index_equal does all this
| result = idx.astype(object) | ||
| assert isinstance(result, Index) | ||
| assert result.dtype == object | ||
| tm.assert_index_equal(result, expected) |
jreback
added
Testing
Codecov Report
@@ Coverage Diff @@
## master #19637 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 150 150
Lines 48807 48807
=======================================
Hits 44716 44716
Misses 4091 4091
Continue to review full report at Codecov.
|
jreback
approved these changes
Feb 11, 2018
|
thanks! |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parametrized as suggested