ERR: include original error message for missing required dependencies #26665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
approved these changes
Jun 5, 2019
jorisvandenbossche
approved these changes
Jun 5, 2019
jorisvandenbossche
changed the title
|
Sorry all, not sure how I missed this was actually not passing CI. |
|
@DanielFEvans sorry, I was a bit fast with merging this (for some reason I overlooked that the CI was red). So for now I reverted the change on master, to avoid that all other PRs will fail. Can you open a new PR with the same changes, but then look into fixing the tests? (I didn't fully find out how to fix them, my attempt is in #26674) |
vaibhavhrt
pushed a commit
to vaibhavhrt/pandas
that referenced
this pull request
Jun 6, 2019
vaibhavhrt
pushed a commit
to vaibhavhrt/pandas
that referenced
this pull request
Jun 6, 2019
…ndencies (pandas-dev#26665)" This reverts commit 047d32d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffModifies the try-catch for imports of required dependencies (
numpy,pytz, anddateutil) to record any exceptions raised, and then to include the message from these when reporting that required dependencies are missing.Previously, the error message simply claimed the dependency was missing, which was somewhat misleading if the dependency was installed but raised its own ImportError (missing sub-dependencies, bad install, etc.).