Skip to content

Fix deletion of temp variables in main namespace (left-over from GH26665) #26674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jorisvandenbossche
Copy link
Member

Fixing my merge of #26665

@pep8speaks
Copy link

pep8speaks commented Jun 5, 2019

Hello @jorisvandenbossche! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-05 20:30:30 UTC

@jorisvandenbossche
Copy link
Member Author

It is unfortunately not working. I can't reproduce it locally, the failures on CI.

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #26674 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26674      +/-   ##
==========================================
- Coverage   41.84%   41.78%   -0.07%     
==========================================
  Files         174      174              
  Lines       50663    50663              
==========================================
- Hits        21201    21168      -33     
- Misses      29462    29495      +33
Flag Coverage Δ
#single 41.78% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 15.78% <0%> (-57.9%) ⬇️
pandas/core/dtypes/concat.py 52.19% <0%> (-1.47%) ⬇️
pandas/io/formats/csvs.py 68.07% <0%> (-1.21%) ⬇️
pandas/io/formats/format.py 50.23% <0%> (-0.94%) ⬇️
pandas/core/internals/blocks.py 51.93% <0%> (-0.83%) ⬇️
pandas/core/dtypes/cast.py 48.59% <0%> (-0.34%) ⬇️
pandas/core/arrays/datetimelike.py 42.78% <0%> (-0.18%) ⬇️
pandas/core/arrays/datetimes.py 65.88% <0%> (-0.16%) ⬇️
pandas/core/frame.py 34.99% <0%> (-0.12%) ⬇️
pandas/core/series.py 45.31% <0%> (-0.11%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7ad5f...7c26264. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #26674 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26674      +/-   ##
==========================================
- Coverage   41.84%   41.78%   -0.07%     
==========================================
  Files         174      174              
  Lines       50663    50663              
==========================================
- Hits        21201    21168      -33     
- Misses      29462    29495      +33
Flag Coverage Δ
#single 41.78% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 15.78% <0%> (-57.9%) ⬇️
pandas/core/dtypes/concat.py 52.19% <0%> (-1.47%) ⬇️
pandas/io/formats/csvs.py 68.07% <0%> (-1.21%) ⬇️
pandas/io/formats/format.py 50.23% <0%> (-0.94%) ⬇️
pandas/core/internals/blocks.py 51.93% <0%> (-0.83%) ⬇️
pandas/core/dtypes/cast.py 48.59% <0%> (-0.34%) ⬇️
pandas/core/arrays/datetimelike.py 42.78% <0%> (-0.18%) ⬇️
pandas/core/arrays/datetimes.py 65.88% <0%> (-0.16%) ⬇️
pandas/core/frame.py 34.99% <0%> (-0.12%) ⬇️
pandas/core/series.py 45.31% <0%> (-0.11%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7ad5f...7c26264. Read the comment docs.

@jorisvandenbossche
Copy link
Member Author

OK, short term solution I reverted the change on master, as I won't be able to fix it this evening. Asked on the original PR to open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants