-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Fix deletion of temp variables in main namespace (left-over from GH26665) #26674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deletion of temp variables in main namespace (left-over from GH26665) #26674
Conversation
Hello @jorisvandenbossche! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-06-05 20:30:30 UTC |
It is unfortunately not working. I can't reproduce it locally, the failures on CI. |
Codecov Report
@@ Coverage Diff @@
## master #26674 +/- ##
==========================================
- Coverage 41.84% 41.78% -0.07%
==========================================
Files 174 174
Lines 50663 50663
==========================================
- Hits 21201 21168 -33
- Misses 29462 29495 +33
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26674 +/- ##
==========================================
- Coverage 41.84% 41.78% -0.07%
==========================================
Files 174 174
Lines 50663 50663
==========================================
- Hits 21201 21168 -33
- Misses 29462 29495 +33
Continue to review full report at Codecov.
|
OK, short term solution I reverted the change on master, as I won't be able to fix it this evening. Asked on the original PR to open a new one. |
Fixing my merge of #26665