Skip to content

CI: change np-dev xfails to not strict #32031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2020
Merged

CI: change np-dev xfails to not strict #32031

merged 1 commit into from
Feb 16, 2020

Conversation

simonjayhawkins
Copy link
Member

follow-up to #32025

@simonjayhawkins simonjayhawkins added CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions labels Feb 15, 2020
simonjayhawkins
simonjayhawkins commented Feb 15, 2020
View reviewed changes
pandas/tests/scalar/timedelta/test_arithmetic.py
@@ -386,6 +386,7 @@ def test_td_div_numeric_scalar(self):
marks=pytest.mark.xfail(
_is_numpy_dev,
reason="https://github.com/pandas-dev/pandas/issues/31992",
strict=False,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test is consistently failing. remove the strict=False?

@jbrockmendel
Copy link
Member

Do we have a good way of knowing when the xfail becomes unnecessary?

@simonjayhawkins
Copy link
Member Author

once we make the test xfail(strict=False), i don't think so. still better than a skip though since we'll see the xpass in the test output

@simonjayhawkins simonjayhawkins mentioned this pull request Feb 16, 2020
Closed
@hasB4K hasB4K mentioned this pull request Feb 16, 2020
Merged
9 tasks
@jreback
Copy link
Contributor

jreback commented Feb 16, 2020

@jbrockmendel ok with this until have time to diagnose / fix the real cause?

@jreback jreback added this to the 1.1 milestone Feb 16, 2020
@jbrockmendel
Copy link
Member

fine by me

@jreback jreback merged commit 4f0568e into pandas-dev:master Feb 16, 2020
simonjayhawkins added a commit to simonjayhawkins/pandas that referenced this pull request Feb 17, 2020
@simonjayhawkins
CI: change np-dev xfails to not strict (pandas-dev#32031)
c2be051
TomAugspurger pushed a commit that referenced this pull request Feb 17, 2020
@simonjayhawkins
Backport PR #32025 and #32031 silence numpy-dev failures (#32057)
ad54c65 
* CI: silence numpy-dev failures (#32025)

* CI: change np-dev xfails to not strict (#32031)

* test_transform_transformation_func not backported
@simonjayhawkins simonjayhawkins deleted the np-dev-xfail-not-strict branch February 18, 2020 10:55
@simonjayhawkins simonjayhawkins modified the milestones: 1.1, 1.0.2 Feb 18, 2020
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
@simonjayhawkins @roberthdevries
CI: change np-dev xfails to not strict (pandas-dev#32031)
848f2f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@simonjayhawkins @jbrockmendel @jreback