Skip to content

CI: change np-dev xfails to not strict #32031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2020
Merged

CI: change np-dev xfails to not strict #32031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pandas/tests/frame/test_cumulative.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ def test_cumprod(self, datetime_frame):
df.cumprod(1)

@pytest.mark.xfail(
_is_numpy_dev, reason="https://github.com/pandas-dev/pandas/issues/31992"
_is_numpy_dev,
reason="https://github.com/pandas-dev/pandas/issues/31992",
strict=False,
)
def test_cummin(self, datetime_frame):
datetime_frame.loc[5:10, 0] = np.nan
Expand All @@ -101,7 +103,9 @@ def test_cummin(self, datetime_frame):
assert np.shape(cummin_xs) == np.shape(datetime_frame)

@pytest.mark.xfail(
_is_numpy_dev, reason="https://github.com/pandas-dev/pandas/issues/31992"
_is_numpy_dev,
reason="https://github.com/pandas-dev/pandas/issues/31992",
strict=False,
)
def test_cummax(self, datetime_frame):
datetime_frame.loc[5:10, 0] = np.nan
Expand Down
4 changes: 3 additions & 1 deletion pandas/tests/groupby/test_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,9 @@ def test_numpy_compat(func):


@pytest.mark.xfail(
_is_numpy_dev, reason="https://github.com/pandas-dev/pandas/issues/31992"
_is_numpy_dev,
reason="https://github.com/pandas-dev/pandas/issues/31992",
strict=False,
)
def test_cummin_cummax():
# GH 15048
Expand Down
1 change: 1 addition & 0 deletions pandas/tests/scalar/timedelta/test_arithmetic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@ def test_td_div_numeric_scalar(self):
marks=pytest.mark.xfail(
_is_numpy_dev,
reason="https://github.com/pandas-dev/pandas/issues/31992",
strict=False,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test is consistently failing. remove the strict=False?

),
),
float("nan"),
Expand Down
8 changes: 6 additions & 2 deletions pandas/tests/series/test_cumulative.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ def test_cumprod(self, datetime_series):
_check_accum_op("cumprod", datetime_series)

@pytest.mark.xfail(
_is_numpy_dev, reason="https://github.com/pandas-dev/pandas/issues/31992"
_is_numpy_dev,
reason="https://github.com/pandas-dev/pandas/issues/31992",
strict=False,
)
def test_cummin(self, datetime_series):
tm.assert_numpy_array_equal(
Expand All @@ -54,7 +56,9 @@ def test_cummin(self, datetime_series):
tm.assert_series_equal(result, expected)

@pytest.mark.xfail(
_is_numpy_dev, reason="https://github.com/pandas-dev/pandas/issues/31992"
_is_numpy_dev,
reason="https://github.com/pandas-dev/pandas/issues/31992",
strict=False,
)
def test_cummax(self, datetime_series):
tm.assert_numpy_array_equal(
Expand Down