[BUG] add consistency to_numeric on empty list #32512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to_numeric should work similarly on empty lists for downcast=unsigned/float/integer Addresses: GH32493
mroeschke
reviewed
Mar 7, 2020
| tm.assert_series_equal(result, ser) | ||
|
|
||
|
|
||
| def test_downcast_empty(): |
Member
There was a problem hiding this comment.
Could you use pytest.mark.parametrize here?
ShaharNaveh
suggested changes
Mar 10, 2020
| @pytest.mark.parametrize("dc1", ["integer", "float", "unsigned"]) | ||
| @pytest.mark.parametrize("dc2", ["integer", "float", "unsigned"]) | ||
| def test_downcast_empty(dc1, dc2): | ||
|
|
Contributor
There was a problem hiding this comment.
Can you add a comment that points to the original issue?
something like:
# https://github.com/pandas-dev/pandas/issues/32493
Should do it
WillAyd
reviewed
Mar 11, 2020
jreback
added
Dtype Conversions
jreback
requested changes
Mar 11, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
lgtm. can you add a whatsnew note in 1.1, bug fixes, numeric section. ping on green.
jreback
requested changes
Mar 14, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
small change, pls merge master and ping on green.
pandas/core/tools/numeric.py
Outdated
| if downcast in ("integer", "signed"): | ||
| typecodes = np.typecodes["Integer"] | ||
| elif downcast == "unsigned" and np.min(values) >= 0: | ||
| elif downcast == "unsigned" and (len(values) == 0 or np.min(values) >= 0): |
Contributor
Author
There was a problem hiding this comment.
small change, pls merge master and ping on green.
@jreback Done 👍
to_numeric should work similarly on empty lists for downcast=unsigned/float/integer Addresses: GH32493
jreback
approved these changes
Mar 16, 2020
Contributor
|
thanks @mikekutzma |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_numeric should work similarly on empty lists for
downcast=unsigned/float/integer
Addresses: GH32493
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff