Skip to content

[BUG] add consistency to_numeric on empty list #32512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 16 commits into from
Mar 16, 2020
Merged

[BUG] add consistency to_numeric on empty list #32512

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a561ab3
[BUG] add consistency to_numeric on empty list
mikekutzma Mar 7, 2020
c7239d5
Add pytest.mark.parametrize to tests
mikekutzma Mar 7, 2020
9ae3c69
Merge branch 'master' of https://github.com/pandas-dev/pandas
mikekutzma Mar 10, 2020
b97e10c
Add pytest.mark.parametrize to tests
mikekutzma Mar 7, 2020
cbac61f
Use len(values) to avoid numpy compat issues
mikekutzma Mar 10, 2020
25403d3
Merge branch 'bugfix/32493' of github.com:mikekutzma/pandas into bugf…
mikekutzma Mar 10, 2020
b1ad5c1
Add whatsnew entry for 32493
mikekutzma Mar 11, 2020
e051ec9
[BUG] add consistency to_numeric on empty list
mikekutzma Mar 7, 2020
587f142
Add pytest.mark.parametrize to tests
mikekutzma Mar 7, 2020
fa6a271
Use len(values) to avoid numpy compat issues
mikekutzma Mar 10, 2020
e19371e
Add whatsnew entry for 32493
mikekutzma Mar 11, 2020
a33732a
Merge remote-tracking branch 'upstream/master'
mikekutzma Mar 15, 2020
8b45bf9
Merge branch 'bugfix/32493' of github.com:mikekutzma/pandas into bugf…
mikekutzma Mar 15, 2020
b6f44e4
Use not len() over len==0 in to_numeric for unsigned
mikekutzma Mar 15, 2020
5c31deb
Merge branch 'master' of github.com:mikekutzma/pandas into bugfix/32493
mikekutzma Mar 15, 2020
f700281
Merge remote-tracking branch 'upstream/master' into bugfix/32493
mikekutzma Mar 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/tools/numeric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def to_numeric(arg, errors="raise", downcast=None):

if downcast in ("integer", "signed"):
typecodes = np.typecodes["Integer"]
elif downcast == "unsigned" and np.min(values) >= 0:
elif downcast == "unsigned" and np.min(values, initial=0) >= 0:
typecodes = np.typecodes["UnsignedInteger"]
elif downcast == "float":
typecodes = np.typecodes["Float"]
Expand Down
9 changes: 9 additions & 0 deletions pandas/tests/tools/test_to_numeric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,3 +627,12 @@ def test_non_coerce_uint64_conflict(errors, exp):
else:
result = to_numeric(ser, errors=errors)
tm.assert_series_equal(result, ser)


@pytest.mark.parametrize("dc1", ["integer", "float", "unsigned"])
@pytest.mark.parametrize("dc2", ["integer", "float", "unsigned"])
def test_downcast_empty(dc1, dc2):

Copy link
Contributor

@ShaharNaveh ShaharNaveh Mar 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment that points to the original issue?

something like:

# https://github.com/pandas-dev/pandas/issues/32493

Should do it

assert np.array_equal(
pd.to_numeric([], downcast=dc1), pd.to_numeric([], downcast=dc2)
)