REF: split describe categorical function #39287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved handing timestamp data from
describe_categorical_1d
intodescribe_timestamp_as_categorical_1d
.Extracted function
select_describe_func
for selecting the proper function, suitable for a given data type.Pros:
FutureWarning
.Cons:
percentiles_ignored
passed into functions for handling categorical types. This is done to unify the interface across all functions for describing a series. The problem will be handled when enabling strategy pattern as the percentiles will become an instance attribute for the strategy class.describe_categorical_1d
intodescribe_timestamp_as_categorical_1d
, which will be handled as the strategy class for categorical data is created (it will be encapsulated there).