Skip to content

BUG: partially-inferring pydatetime objects #44296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2021
Merged

BUG: partially-inferring pydatetime objects #44296

merged 1 commit into from
Nov 4, 2021
+35 −7

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 2, 2021 •
edited by jreback
Loading

simonjayhawkins
simonjayhawkins reviewed Nov 3, 2021
View reviewed changes
pandas/tests/tools/test_to_datetime.py
)
tm.assert_series_equal(mixed, expected)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this PR fully close the issue? The issue refers to this as not being idempotent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can keep it open with a comment that the idempotency has not been addressed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

pandas/tests/tools/test_to_datetime.py
with pytest.raises(ValueError, match="Tz-aware datetime.datetime"):
to_datetime(ser)
to_datetime(mixed)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this second call to to_datetime should be a no-op?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely; treating that as separate

@jreback jreback added this to the 1.4 milestone Nov 3, 2021
@jreback jreback added the Datetime Datetime data dtype label Nov 3, 2021
@jreback
Copy link
Contributor

jreback commented Nov 3, 2021

cc @mroeschke if any comments

@jreback jreback merged commit 4d507b0 into pandas-dev:master Nov 4, 2021
@jbrockmendel jbrockmendel deleted the bug-40111 branch November 4, 2021 01:11
@jbrockmendel jbrockmendel mentioned this pull request Nov 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@jreback jreback jreback approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrockmendel @jreback @mroeschke @simonjayhawkins