-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: partially-inferring pydatetime objects #44296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1123,17 +1123,32 @@ def test_iso8601_strings_mixed_offsets_with_naive(self): | |
|
||
def test_mixed_offsets_with_native_datetime_raises(self): | ||
# GH 25978 | ||
ser = Series( | ||
|
||
vals = [ | ||
"nan", | ||
Timestamp("1990-01-01"), | ||
"2015-03-14T16:15:14.123-08:00", | ||
"2019-03-04T21:56:32.620-07:00", | ||
None, | ||
] | ||
ser = Series(vals) | ||
assert all(ser[i] is vals[i] for i in range(len(vals))) # GH#40111 | ||
|
||
mixed = to_datetime(ser) | ||
expected = Series( | ||
[ | ||
"nan", | ||
"NaT", | ||
Timestamp("1990-01-01"), | ||
"2015-03-14T16:15:14.123-08:00", | ||
"2019-03-04T21:56:32.620-07:00", | ||
Timestamp("2015-03-14T16:15:14.123-08:00").to_pydatetime(), | ||
Timestamp("2019-03-04T21:56:32.620-07:00").to_pydatetime(), | ||
None, | ||
] | ||
], | ||
dtype=object, | ||
) | ||
tm.assert_series_equal(mixed, expected) | ||
|
||
with pytest.raises(ValueError, match="Tz-aware datetime.datetime"): | ||
to_datetime(ser) | ||
to_datetime(mixed) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this second call to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. likely; treating that as separate |
||
|
||
def test_non_iso_strings_with_tz_offset(self): | ||
result = to_datetime(["March 1, 2018 12:00:00+0400"] * 2) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this PR fully close the issue? The issue refers to this as not being idempotent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can keep it open with a comment that the idempotency has not been addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm