Varargs1 #9
Open
Varargs1 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlrobertson
force-pushed
the
varargs1
branch
3 times, most recently
from
9dca909 to
0322ede
Compare
dlrobertson
force-pushed
the
varargs1
branch
9 times, most recently
from
071f362 to
5645330
Compare
dlrobertson
force-pushed
the
varargs1
branch
10 times, most recently
from
4eec6aa to
05a78a3
Compare
The reverse conversion unfortunately causes unexpected errors like:
```
error[E0277]: the trait bound `!: std::convert::From<()>` is not satisfied
--> src/librustc_metadata/encoder.rs:105:9
|
105 | self.emit_usize(seq.len)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::convert::From<()>` is not implemented for `!`
|
= help: the following implementations were found:
<! as std::convert::From<std::convert::Infallible>>
= note: the trait is implemented for `()`. Possibly this error has been caused by changes to Rust's type-inference algorithm (see: rust-lang#48950 for more info). Consider whether you meant to use the type `()` here instead.
= note: required by `std::convert::From::from`
```
I don’t understand why this error happens.
If I’m reading the code correctly the return types of `emit_usize`
and of the method that contains line 105 are both `Result<(), !>`,
so the expansion of the `?` operator should involve `!: From<!>`,
not `From<()>`.
Is this a type inference bug?
This functionality has lived for a while in the tokio ecosystem, where it can improve performance by minimizing copies.
Returning &'a mut [u8] was unsound, and we may as well just have them directly deref to their slices to make it easier to work with them.
dlrobertson
force-pushed
the
varargs1
branch
from
f517268 to
21285da
Compare
dlrobertson
force-pushed
the
varargs1
branch
from
21285da to
6f7a016
Compare
dlrobertson
force-pushed
the
varargs1
branch
2 times, most recently
from
7b549b3 to
5ca1743
Compare
Stabilize TryFrom and TryInto with a convert::Infallible empty enum This is the plan proposed in rust-lang#33417 (comment)
Stabilize `unrestricted_attribute_tokens` In accordance with a plan described in https://internals.rust-lang.org/t/unrestricted-attribute-tokens-feature-status/8561/3. Delimited non-macro non-builtin attributes now support the same syntax as macro attributes: ``` PATH PATH `(` TOKEN_STREAM `)` PATH `[` TOKEN_STREAM `]` PATH `{` TOKEN_STREAM `}` ``` Such attributes mostly serve as inert proc macro helpers or tool attributes. To some extent these attributes are de-facto stable due to a hole in feature gate checking (feature gating is done too late - after macro expansion.) So if macro *removes* such helper attributes during expansion (and it must remove them, unless it's a derive macro), then the code will work on stable. Key-value non-macro non-builtin attributes are now restricted to bare minimum required to support what we support on stable - unsuffixed literals (rust-lang#34981). ``` PATH `=` LITERAL ``` (Key-value macro attributes are not supported at all right now.) Crater run in rust-lang#57321 found no regressions for this change. There are multiple possible ways to extend key-value attributes (rust-lang#57321 (comment)), but I'd expect an RFC for that and it's not a pressing enough issue to block stabilization of delimited attributes. Built-in attributes are still restricted to the "classic" meta-item syntax, nothing changes here. rust-lang#57321 goes further and adds some additional restrictions (more consistent input checking) to built-in attributes. Closes rust-lang#55208
Add vectored read and write support This functionality has lived for a while in the tokio ecosystem, where it can improve performance by minimizing copies. r? @alexcrichton
Remove NodeId from some HIR nodes The next iteration of rust-lang#57578. Removes `NodeId` from: - [x] `Lifetime` - [x] `Ty` - [x] `GenericParam` - [x] `WhereClause` - [x] `WhereEqPredicate` - [x] `MacroDef` - [x] `Block` - [x] `Expr` r? @Zoxc
dlrobertson
force-pushed
the
varargs1
branch
from
5ca1743 to
e556098
Compare
Change-Id: I3fa00e999a2ee4eb72db1fdf53a8633b49176a18
dlrobertson
force-pushed
the
varargs1
branch
from
e556098 to
3954071
Compare
Update stdsimd This updates stdsimd to a Rust2015 / Rust2018 compatible version. Once this is merged it should be possible to migrate libcore and libstd to Rust2018. Once that happens, we can just require the 2018 edition in stdsimd.
[Step 1] Implement "small substs optimization" for substs of length 1 addresses part of rust-lang#58310 r?@arielb1
Update book submodule Updates the book to the latest commit This is to include [documentation SEO fix](rust-lang/book#1788) ASAP.
…r=alexreg Allow lang and lib features to share names Fixes rust-lang#58715. I didn't add a test, because there's currently no standard lang test feature and I felt apprehensive about adding a permanently unstable feature. Instead, a shared lang/lib feature will be used in rust-lang#57760 and will essentially provide an immediately test.
Add support for defining C compatible variadic functions in unsafe rust with extern "C".
- Add the c_variadic language feature - Add the c_variadic library feature
- Move closures defined in codegen_terminator into a separate helper structure and implementation. - Create helper functions for each of the complex match arms on the terminators kind in codegen_terminator.
Function signatures with the `variadic` member set are actually C-variadic functions. Make this a little more explicit by renaming the `variadic` boolean value, `c_variadic`.
dlrobertson
force-pushed
the
varargs1
branch
from
3954071 to
f7dd438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.