-
-
Notifications
You must be signed in to change notification settings - Fork 206
refactor: fix analyzer code style warnings #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request!
|
414e8d6
to
a93f088
Compare
Each |
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
==========================================
+ Coverage 3.34% 10.28% +6.93%
==========================================
Files 4 48 +44
Lines 269 2810 +2541
==========================================
+ Hits 9 289 +280
- Misses 260 2521 +2261
Continue to review full report at Codecov.
|
…ter into simple-infos
Kindly request a review when this is ready; not sure if you are currently waiting for review |
Didn't test it yet. I'll request a review when I did. |
It works as expected, but I'll revert the change since it would be breaking. Older versions of Flutter (before v2.2.0-10.1.pre) require |
Continue using vsync in _ParseLiveListElementWidgetState to avoid a breaking change.
codecov should be fine. Might be due to more compact format or fewer imports. |
Sorry @phillwiggins pressed the wrong button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the changelog entries to the corresponding packages? Entries should only go to the package in which the changes occur. We do separate releases and versioning now. See #668 (comment)
If this PR does not fix a bug, add a feature or improve performance, but is merely a refactor to get rid of recommended code style changes, then this would not lead to a changelog entry. The PR would simply be merged as something like refactor: fix analyzer code style warnings
. I renamed the PR title; if that's incorrect, please rename accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's try out this first dart - flutter combo release!
Oops, we forgot forgot to bump the package versions. I guess we can just wait for the next PR, probably #738, and do a release. Unless you feel like opening another PR just for the version bump. |
Oops...
If you want, I can do it. It might be best to test it soon rather then later. |
Sure, please go ahead |
Link it to #733? |
New Pull Request Checklist
Issue Description
This PR fixes the trivial, non breaking analyzer infos.
Related issue: #733
Approach
Mostly I just let the ide fix it.
TODOs before merging
- [ ] Make sure the change to_ParseLiveListElementWidgetState
did not break anything.