Skip to content

ci: bump versions for next release #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2022

Conversation

fischerscode
Copy link
Contributor

@fischerscode fischerscode commented May 30, 2022

New Pull Request Checklist

Issue Description

Bumping the versions, since #734 did not cover it.

Related issue: #733

Approach

Left the parse_server_sdk dependency in the flutter package at ^3.1.0.

Not sure if the title really fits. Feel free to edit. ci: seems best to me.

TODOs before merging

n/a

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 30, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@fischerscode fischerscode requested a review from mtrezza May 30, 2022 20:04
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #757 (efc34b2) into master (b7fa707) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   10.28%   10.28%           
=======================================
  Files          48       48           
  Lines        2810     2810           
=======================================
  Hits          289      289           
  Misses       2521     2521           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7fa707...efc34b2. Read the comment docs.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'd also need to change the dart dependency version in the flutter package. Obviously we would do that only if there was a change in dart that is required in the flutter package. This isn't the case here, but we want to test the release process.

@fischerscode
Copy link
Contributor Author

but we want to test the release process

👍

@fischerscode fischerscode requested a review from mtrezza May 30, 2022 20:34
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets make the release

@mtrezza mtrezza merged commit 3c5ee89 into parse-community:master May 30, 2022
@mtrezza
Copy link
Member

mtrezza commented May 30, 2022

Worked nicely, thanks for this PR for testing, so we can be sure now.

@mbfakourii mbfakourii mentioned this pull request Dec 20, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants