-
-
Notifications
You must be signed in to change notification settings - Fork 207
fix: Custom JSON encoder for List and Map doesn't work correctly in full
mode
#789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix full json data for parseEncode
Thanks for opening this pull request!
|
Codecov ReportBase: 10.26% // Head: 10.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #789 +/- ##
==========================================
+ Coverage 10.26% 10.67% +0.40%
==========================================
Files 49 47 -2
Lines 2815 2810 -5
==========================================
+ Hits 289 300 +11
+ Misses 2526 2510 -16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Could you please rephrase the PR title? It will become the changelog entry and a developer should be able to understand what this fixes without reading the PR. |
I will reformat the title to use the proper commit message syntax. |
full
mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test to demonstrate what is not working correctly?
test added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a lint issue, not sure what it is, because the logs don't show any specific message. Do you have any idea?
It is for Dart code format |
Indeed, the tests pass, now we just need a review from @parse-community/flutter-sdk-review |
full
modefull
mode
There has been no additional review, but I'll go ahead and merge it anyway; if there is an issue, we'll find out. Could you please:
|
Changes were added in file changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
New Pull Request Checklist
Issue Description
Solve the parseEncode problem in list and map
and test added
Related issue: #788
Approach
The
full: full
was added for when we use the list and map in parseEncode and toJsonTODOs before merging