-
-
Notifications
You must be signed in to change notification settings - Fork 207
fix: Custom JSON encoder for List and Map doesn't work correctly in full
mode
#789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ba5bf18
fix parseEncode
mbfakourii c3e0cb6
add parse encoder test
mbfakourii 4368671
improve test code parse_encoder_test.dart
mbfakourii 4862b45
Update packages/dart/lib/src/utils/parse_encoder.dart
mtrezza f88a01b
Update packages/dart/lib/src/utils/parse_encoder.dart
mtrezza 927b9eb
Update packages/dart/lib/src/utils/parse_encoder.dart
mtrezza 1c99f64
Update packages/dart/lib/src/utils/parse_encoder.dart
mtrezza 92a3867
fix lint error for dart code format
mbfakourii a471393
Dart version number was increased
mbfakourii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import 'package:parse_server_sdk/parse_server_sdk.dart'; | ||
import 'package:test/test.dart'; | ||
|
||
void main() { | ||
test( | ||
'should return expectedResult json when json has Nested map and list data.', | ||
() async { | ||
// arrange | ||
await Parse().initialize( | ||
'appId', | ||
'https://test.parse.com', | ||
debug: true, | ||
// to prevent automatic detection | ||
fileDirectory: 'someDirectory', | ||
// to prevent automatic detection | ||
appName: 'appName', | ||
// to prevent automatic detection | ||
appPackageName: 'somePackageName', | ||
// to prevent automatic detection | ||
appVersion: 'someAppVersion', | ||
); | ||
|
||
ParseObject parseObject2 = ParseObject("objectId2"); | ||
parseObject2.objectId = "objectId2"; | ||
|
||
// List and Map | ||
parseObject2 | ||
.setAdd("dataParseObjectList", ["ListText1", "ListText2", "ListText3"]); | ||
parseObject2.setAdd("dataParseObjectMap", { | ||
'KeyTestMap1': 'ValueTestMap1', | ||
'KeyTestMap2': 'ValueTestMap2', | ||
'KeyTestMap3': 'ValueTestMap3', | ||
}); | ||
|
||
// parseObject2 inside parseObject1 | ||
ParseObject parseObject1 = ParseObject("parseObject1"); | ||
parseObject1.objectId = "objectId1"; | ||
parseObject1.setAdd("dataParseObject2", parseObject2); | ||
|
||
// desired output | ||
String expectedResult = | ||
"{className: parseObject1, objectId: objectId1, dataParseObject2: {__op: Add, objects: [{className: objectId2, objectId: objectId2, dataParseObjectList: {__op: Add, objects: [[ListText1, ListText2, ListText3]]}, dataParseObjectMap: {__op: Add, objects: [{KeyTestMap1: ValueTestMap1, KeyTestMap2: ValueTestMap2, KeyTestMap3: ValueTestMap3}]}}]}}"; | ||
|
||
// act | ||
dynamic actualResult = parseEncode(parseObject1, full: true); | ||
|
||
//assert | ||
expect(actualResult.toString(), expectedResult); | ||
}); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.