-
-
Notifications
You must be signed in to change notification settings - Fork 596
Add methods addAll
, addAllUnique
and removeAll
#459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add new tests instead of altering existing ones?
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 85.39% 85.41% +0.02%
==========================================
Files 46 46
Lines 3724 3730 +6
Branches 854 854
==========================================
+ Hits 3180 3186 +6
Misses 544 544
Continue to review full report at Codecov.
|
@arniu on the implementation side, those all all the same as add, addUnique, remove etc... Why not just change the accepted type to |
@flovilmart This is mainly due to compatibility considerations:
In the old version, you can use var obj = new Parse.Object('TestObject')
obj.add('array', [1, 2])
obj.add('array', [1, 2]) The result is If you allow |
My bad, I misread the code, as it looked very similar :) |
* Add Type Polygon to Schema and PolygonContains to query * Corrects Guide Link in README.md (#457) Just a small fix of `https` to `http` for the JS guide link, which is only available over `http`. * Addresses flaky test (#458) * Update ParseGeoPointTest.js * Limit request attempts to 1 * explore * Marks flaky test as pending * Add methods `addAll`, `addAllUnique` and `removeAll` (#459) * Add methods `addAll`, `addAllUnique` and `removeAll` * Add methods `addAll`, `addAllUnique` and `removeAll` * Add test for `addAll`, `addAllUnique` and `removeAll` * Revert test case * containsPoint uses bounded box first then ray casting * update parse-server to 2.6.0 * Add Type Polygon to Schema and PolygonContains to query * containsPoint uses bounded box first then ray casting * update parse-server to 2.6.0
No description provided.