Skip to content

Add Type Polygon to Schema and PolygonContains to query #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 30, 2017

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 6, 2017

New Polygon Type and new Query for finding all polygons that contains a point

parse-community/parse-server#3944

Waiting for 2.6.0 release

dplewis and others added 5 commits July 6, 2017 13:29
Just a small fix of `https` to `http` for the JS guide link, which is only available over `http`.
* Update ParseGeoPointTest.js

* Limit request attempts to 1

* explore

* Marks flaky test as pending
…#459)

* Add methods `addAll`, `addAllUnique` and `removeAll`

* Add methods `addAll`, `addAllUnique` and `removeAll`

* Add test for `addAll`, `addAllUnique` and `removeAll`

* Revert test case
uses bounded box first then ray casting
@codecov
Copy link

codecov bot commented Aug 8, 2017

Codecov Report

Merging #455 into master will decrease coverage by 1.36%.
The diff coverage is 12.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   85.39%   84.03%   -1.37%     
==========================================
  Files          46       47       +1     
  Lines        3724     3795      +71     
  Branches      854      868      +14     
==========================================
+ Hits         3180     3189       +9     
- Misses        544      606      +62
Impacted Files Coverage Δ
src/ParsePolygon.js 0% <0%> (ø)
src/ParseQuery.js 94.03% <0%> (-0.54%) ⬇️
src/ParseObject.js 86.55% <100%> (+0.1%) ⬆️
src/encode.js 100% <100%> (ø) ⬆️
src/Parse.js 81.81% <100%> (+0.27%) ⬆️
src/decode.js 96.66% <50%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30cc5fc...befeb82. Read the comment docs.

@dplewis
Copy link
Member Author

dplewis commented Aug 30, 2017

@flovilmart can you look at this?

@flovilmart
Copy link
Contributor

This looks great man!

@flovilmart flovilmart merged commit 293e2e1 into parse-community:master Aug 30, 2017
@dplewis dplewis deleted the type-polygon branch January 16, 2018 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants