Add Polygon Type To Schema / PolygonContain to Query #3944
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3944 +/- ##
==========================================
+ Coverage 90.59% 90.68% +0.08%
==========================================
Files 116 116
Lines 7793 7889 +96
==========================================
+ Hits 7060 7154 +94
- Misses 733 735 +2
Continue to review full report at Codecov.
|
dplewis
changed the title
|
@flovilmart Done, Let me know if I need more tests |
dplewis
changed the title
|
Mongo only throws errors if indexes are set. I found that mongo throws an error for self-intersecting polygons. Is it ok if mongo just throws an error?
https://github.com/mongodb/mongo/blob/master/src/mongo/db/geo/geoparser.cpp#L223 I need to check for invalid loops if not users can set invalid polygons and could break once they add indexes later on. Maybe we can add geoJson validator dependencies to parse-server and sdks. Eventually we will need it for LineString, MultiPoint, MultiLineString,MultiPolygon,GeometryCollection |
|
Is it possible to enforce the indexing when adding those columns types the same way we do with 2D indexes? |
|
Since $geoIntersect doesn't require a index I can't catch an error to add one like $near. I could check the schema and if Polygon Type add an index on object creation. I'm going to write a few more test for postgres. It doesn't throw errors right now but It may for indexes. |
|
@flovilmart how does this look? |
|
I’ll have a deeper look after the 2.5.0 release :) |
|
Why the removal of the test, |
|
I noticed when a mongoError gets thrown it retries the request a few times. Is that normal? I added it back |
The JS SDK is retrying dumbly. |
There was a problem hiding this comment.
Overall looks awesome @dplewis ! A few nits here and there before we get that one in!
| @@ -25,6 +25,7 @@ function mongoFieldToParseSchemaField(type) { | |||
| case 'geopoint': return {type: 'GeoPoint'}; | |||
| case 'file': return {type: 'File'}; | |||
| case 'bytes': return {type: 'Bytes'}; | |||
| case 'polygon': return {type: 'Polygon'}; | |||
| @@ -98,6 +99,7 @@ function parseFieldTypeToMongoFieldType({ type, targetClass }) { | |||
| case 'GeoPoint': return 'geopoint'; | |||
| case 'File': return 'file'; | |||
| case 'Bytes': return 'bytes'; | |||
| case 'Polygon': return 'polygon'; | |||
| @@ -182,7 +182,8 @@ export class MongoStorageAdapter { | |||
|
|
|||
| addFieldIfNotExists(className, fieldName, type) { | |||
| return this._schemaCollection() | |||
| .then(schemaCollection => schemaCollection.addFieldIfNotExists(className, fieldName, type)); | |||
| .then(schemaCollection => schemaCollection.addFieldIfNotExists(className, fieldName, type)) | |||
| .then(() => this.create2dsphereIndex(className, fieldName, type)); | |||
There was a problem hiding this comment.
can you rename create2dsphereIndex into an umbrella createIndexesIfNeeded? more explicit :)
|
|
||
| create2dsphereIndex(className, fieldName, type) { | ||
| if (type && type.type === 'Polygon') { | ||
| const index = {} |
There was a problem hiding this comment.
you can use:
const index = {
[fieldName]: '2dsphere'
};
and remove the next line
|
Thanks for the feedback. Changes have been made |
#3942
Adds Mongo and PG support for Polygon Type and PolygonContain query