Skip to content

fix some interactions between select queries and sub objects #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

dstarke
Copy link
Contributor

@dstarke dstarke commented Sep 9, 2017

Fixes some issues introduced by #409, and I think should fix #475.

@codecov
Copy link

codecov bot commented Sep 10, 2017

Codecov Report

Merging #477 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
+ Coverage   84.03%   84.04%   +0.01%     
==========================================
  Files          47       47              
  Lines        3795     3798       +3     
  Branches      868      869       +1     
==========================================
+ Hits         3189     3192       +3     
  Misses        606      606
Impacted Files Coverage Δ
src/ParseQuery.js 94.08% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 293e2e1...6dceb90. Read the comment docs.

@dstarke
Copy link
Contributor Author

dstarke commented Sep 11, 2017

Ref: parse-community/parse-server#3999
This should address the issues described there.

@flovilmart
Copy link
Contributor

Thanks @dstarke

@flovilmart
Copy link
Contributor

@dstarke I just tested the integration with parse-server and it breaks 2 tests:

    ✗ select nested keys 2 level (issue #1567)
      - TypeError: Cannot read property 'bazoo' of undefined
    ✗ select nested keys 2 level without include (issue #3185)
      - TypeError: Cannot read property 'bazoo' of undefined

I'll have a look

@flovilmart flovilmart mentioned this pull request Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Query.select() will break ParseObject.has() on undefined field
2 participants