Using Query.select() will break ParseObject.has() on undefined field from 2.5.1

[promisenxu]

Issue Description

Starting from Parse Server 2.5.1, if a query has Query.select() , calling .has() on the returned object with a selected field that's undefined will return true.

Steps to reproduce

var query = new Parse.Query('ClassName');
query.include('FieldName');
query.select('FieldName');
query.get('objectId', {useMasterKey: true}).then(result => {
// Assume FieldName is undefined for the returned object
result.has('FiledName'); // This will return true.
});

Expected Results

.has() on a field with undefined value should return false, which is the behaviour up to 2.5.0.

Actual Outcome

Return true.

Environment Setup

• Server

  • parse-server version (Be specific! Don't say 'latest'.) : 2.5.1, 2.5.2, 2.5.3
  • Localhost or remote server? (AWS, Heroku, Azure, Digital Ocean, etc): Heroku

• Database

  • MongoDB version: 3.0.11 (MMAPv1)
  • Localhost or remote server? (AWS, mLab, ObjectRocket, Digital Ocean, etc): mLab

[flovilmart]

Thanks for reporting the issue! We’ll have a look shortly!

[adirgan]

This affected my application also I had to return from version to 2.5.0 because I can not get certain data

[flovilmart]

@adirgan, @promisenxu I just added a test, and waiting for CI to complete, but so far, this test works as expected. #4004. Can you please tell me where this test doesn't match your issue? Also, can you post the logs when running with VERBOSE=1?

[logicsb]

i had same problem, when i use select and the field is pointer type and the value is undefined. the new parse version returns an JSON with all fields of this pointer with undefined value. Expected are the selected field return an undefined value not an JSON object with undefined values on the fields.

[flovilmart]

So is it possible to tell me where my test is wrong??

[logicsb]

On your test @flovilmart you have set an empty object on the field named 'field'. In my case, the value of the 'field' should be undefined to replicate the issue

[flovilmart]

In my test, the obj has no value for the field key, and obj1 has an object. And it works as expected. Can you post and example test that fails at CI because I don’t get it

[logicsb]

I think its simple. You can add console.log(result.get('field')) on your test. In this case are expected undefined. In my case returns an json like {"__type":"Pointer","className":"OtherObject","objectId":undefined} and all of others fields have undefined value. If you need i can provide an screen with log with VERBOSE=1

[flovilmart]

But you realize that the obj.has(‘field’) works as expected right?

[flovilmart]

@logicsb verbose logs of the query response:

verbose: REQUEST for [GET] /1/classes/TestObject: {
  "where": {},
  "include": "field",
  "keys": "field"
} method=GET, url=/1/classes/TestObject, user-agent=node-XMLHttpRequest, Parse/js1.10.0 (NodeJS 7.4.0), accept=*/*, content-type=text/plain, host=localhost:8378, content-length=194, connection=close, , include=field, keys=field
verbose: RESPONSE from [GET] /1/classes/TestObject: {
  "response": {
    "results": [
      {
        "objectId": "7IsbXHTdSW",
        "createdAt": "2017-07-11T23:16:38.388Z",
        "updatedAt": "2017-07-11T23:16:38.388Z"
      },
      {
        "objectId": "puId6aR3zn",
        "field": {
          "objectId": "JMchm2AACl",
          "createdAt": "2017-07-11T23:16:38.388Z",
          "updatedAt": "2017-07-11T23:16:38.388Z",
          "__type": "Object",
          "className": "OtherObject"
        },
        "createdAt": "2017-07-11T23:16:38.610Z",
        "updatedAt": "2017-07-11T23:16:38.610Z"
      }
    ]
  }
} results=[objectId=7IsbXHTdSW, createdAt=2017-07-11T23:16:38.388Z, updatedAt=2017-07-11T23:16:38.388Z, objectId=puId6aR3zn, objectId=JMchm2AACl, createdAt=2017-07-11T23:16:38.388Z, updatedAt=2017-07-11T23:16:38.388Z, __type=Object, className=OtherObject, createdAt=2017-07-11T23:16:38.610Z, updatedAt=2017-07-11T23:16:38.610Z]
verbose: REQUEST for [GET] /1/classes/TestObject: {
  "where": {},
  "include": "field",
  "keys": "field"
} method=GET, url=/1/classes/TestObject, user-agent=node-XMLHttpRequest, Parse/js1.10.0 (NodeJS 7.4.0), accept=*/*, content-type=text/plain, host=localhost:8378, content-length=194, connection=close, , include=field, keys=field
verbose: RESPONSE from [GET] /1/classes/TestObject: {
  "response": {
    "results": [
      {
        "objectId": "7IsbXHTdSW",
        "createdAt": "2017-07-11T23:16:38.388Z",
        "updatedAt": "2017-07-11T23:16:38.388Z"
      },
      {
        "objectId": "puId6aR3zn",
        "field": {
          "objectId": "JMchm2AACl",
          "createdAt": "2017-07-11T23:16:38.388Z",
          "updatedAt": "2017-07-11T23:16:38.388Z",
          "__type": "Object",
          "className": "OtherObject"
        },
        "createdAt": "2017-07-11T23:16:38.610Z",
        "updatedAt": "2017-07-11T23:16:38.610Z"
      }
    ]
  }
} results=[objectId=7IsbXHTdSW, createdAt=2017-07-11T23:16:38.388Z, updatedAt=2017-07-11T23:16:38.388Z, objectId=puId6aR3zn, objectId=JMchm2AACl, createdAt=2017-07-11T23:16:38.388Z, updatedAt=2017-07-11T23:16:38.388Z, __type=Object, className=OtherObject, createdAt=2017-07-11T23:16:38.610Z, updatedAt=2017-07-11T23:16:38.610Z]

[flovilmart]

I'd gladly resolve the issue if only I could reproduce it

[logicsb]

In my case the issue is:

{  
      "createdAt":"2017-07-11T22:45:41.835Z",
      "updatedAt":"2017-07-12T01:00:45.819Z",
      "hive":{  },
      "object":{  
         "actor":{ },
         "group":{  
            "hive":{ }
         },
         "hive":{}
      },
      "objectId":"EscZ2woUYv"
}

hive: is a pointer to Hive and value is undefined on the parse-dashboard
object: is a pointer to Activity and value is undefined on the parse-dashboard
actor: is a pointer to _User and value is undefined on the parse-dashboard
...

I don't know, but before update the parse version, "object" field does not apear on the response JSON because your value is undefined.

i'm using select like

query.select("object")
query.select("object.actor")
query.select("object.group")
query.select("object.group.hive")
....

I think before version of parse are correct, if "object" is undefined don't need send an empty object on the response.

[flovilmart]

Can you provide some code/open a PR with a failing test please?

[logicsb]

I think i have found the situation to cause this issue:

class Foo (name:String, status:String, content:String, object:Pointer< Foo>, user:Pointer<_User>)

var query = new Parse.Query("Foo");
query.include("object")
query.include("user")
query.select([
    'user',
    'user.name',
    'name',
    'content',
    'object',
    'object.name',
    'object.content'
])

if the object field is undefined this will return a JSON like:

{
    "user" : {"name" : "Smith"},
    "name" : "bla",
    "content" : "bla bla",
     "object" : {
         "user" : {}
     }
}

[dplewis]

@flovilmart @montymxb This is how I reproduced the issue. This is a JS-SDK issue

  const obj = new Parse.Object('TestObject'); // Yay no foo
    obj.save().then(() => {
      const query = new Parse.Query('TestObject');
      query.select('foo');
      return query.get(obj.id);
    }).then((result) => {
      expect(result.has('foo')).toBe(false); // result.has('foo') returns true ?!?? :(
      done();
    }).catch(done.fail);

[dstarke]

There was an issue in the JS-SDK where a query that selected sub-objects would cause the client to inject empty sub-objects at the parent levels in the selection path if an element in that path was not returned by the query. I believe that is the cause of the issues described here.

I have submitted a pull request to the JS-SDK with a fix along with some test cases for the root cause of this: parse-community/Parse-SDK-JS#477

[flovilmart]

@dstarke, before we merge the JS fixes, I’ll add a test here to make sure he fix is efficient and we have no other regressions in here.

[flovilmart]

@dplewis I ran your repro in the test suite, and it still didn't fail :/ Not sure how to go from there.

[promisenxu]

Sorry for abandoning this thread - was dealing with some personal issues.

I'm not sure what is the current status of this. It seems that parse-community/Parse-SDK-JS#477 should fix this?

Let me try to create a test for this repo for this issue.

[promisenxu]

@flovilmart Figure out how to write a failed test case for this issue - the caveat is to also select a field of the pointer field. Pull Request #4245

[flovilmart]

thanks for jumping back on it! We’ll review shortly and test against The fixed JS SDK :)