Skip to content

Adds test for #3999 #4004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Adds test for #3999 #4004

wants to merge 2 commits into from

Conversation

flovilmart
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 8, 2017

Codecov Report

Merging #4004 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4004      +/-   ##
==========================================
+ Coverage    90.7%   90.72%   +0.02%     
==========================================
  Files         116      116              
  Lines        7916     7916              
==========================================
+ Hits         7180     7182       +2     
+ Misses        736      734       -2
Impacted Files Coverage Δ
src/RestWrite.js 93.16% <0%> (+0.18%) ⬆️
src/RestQuery.js 95.43% <0%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f00e6...e8dce2d. Read the comment docs.

@montymxb
Copy link
Contributor

@flovilmart looked back at #3999 and not sure what I'm missing...Seems that this case shows the current server works as expected? The only real difference I can pick out is that the original issue used the master key, but I don't really think that alone would cause this. Perhaps it's the type of the field that could cause it.

Anyways, considering that this passes, and we don't have a solid failure case yet, should we keep this open? Or should we hang on for a bit and see if the issue turns up anything conclusive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants