-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
refactor: upgrade webpack deps #1939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade webpack deps #1939
Conversation
Thanks for opening this pull request!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! To clarify, this is a breaking change because the node engine is bumped from 12.0.0 to 12.13.0, is that intended and correct?
Yes, it is correct and intended, it is only for dev-only though, but there is no way to specify the environment unfortunately so all users would be affected. |
I've merged some other PRs and the min Node.js version is now 12.22.0, so this shouldn't be an issue. |
🎉 This change has been released in version 4.0.0-alpha.5 |
🎉 This change has been released in version 4.0.0-beta.1 |
🎉 This change has been released in version 4.0.0 |
* release: (41 commits) chore(release): 4.0.0 [skip ci] ci: release commit chore(release): 4.0.0-beta.2 [skip ci] fix: various UI bugs (e.g. filter data browser, switch app, upload file) (parse-community#2014) chore(release): 4.0.0-beta.1 [skip ci] ci: release commit refactor: upgrade graphiql from 1.5.8 to 1.5.12 (parse-community#1971) refactor: upgrade otpauth from 7.0.7 to 7.0.8 (parse-community#1970) refactor: upgrade typescript from 4.4.4 to 4.5.2 (parse-community#1953) refactor: upgrade graphiql from 1.5.7 to 1.5.8 (parse-community#1968) ci: bump environment (parse-community#1966) refactor: upgrade graphiql from 1.5.5 to 1.5.7 (parse-community#1964) refactor: upgrade graphiql from 1.5.1 to 1.5.5 (parse-community#1963) chore(release): 4.0.0-alpha.5 [skip ci] fix: opening filter menu in data browser leads to blank page (parse-community#1958) refactor: upgrade graphql from 16.0.0 to 16.0.1 (parse-community#1955) refactor: use new React context API (parse-community#1948) refactor: use buttons instead of deprecated javascript URLs (parse-community#1940) refactor: upgrade webpack deps (parse-community#1939) chore(release): 4.0.0-alpha.4 [skip ci] ... # Conflicts: # package-lock.json # src/dashboard/Data/Jobs/JobEdit.react.js # src/dashboard/Data/Jobs/Jobs.react.js
New Pull Request Checklist
Issue Description
This PR upgrades webpack along with style loaders. Due to changes in
css-loader
and change of the exported modules from CSS module I had to change some of the imports in the codebase. There is also the need to change the required node version to the one required by bothstyle-loader
andcss-loader
. Fortunately at the end there is a lot of dependencies less in thenode_modules
.Related issue: #1902
Approach
TODOs before merging