-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
refactor: use new React context API #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mtrezza
merged 14 commits into
parse-community:alpha
from
damianstasik:refactor-legacy-context
Dec 8, 2021
Merged
refactor: use new React context API #1948
mtrezza
merged 14 commits into
parse-community:alpha
from
damianstasik:refactor-legacy-context
Dec 8, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
mtrezza
approved these changes
Dec 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, that's quite an amazing PR!
🎉 This change has been released in version 4.0.0-alpha.5 |
🎉 This change has been released in version 4.0.0-beta.1 |
Cześć @visualfanatic, QQ: do you have an idea what could go wrong here? #1991 |
damianstasik
pushed a commit
to damianstasik/parse-dashboard
that referenced
this pull request
Jan 22, 2022
5 tasks
4 tasks
🎉 This change has been released in version 4.0.0 |
beiguancyc
pushed a commit
to beiguancyc/parse-dashboard
that referenced
this pull request
Feb 8, 2022
* release: (41 commits) chore(release): 4.0.0 [skip ci] ci: release commit chore(release): 4.0.0-beta.2 [skip ci] fix: various UI bugs (e.g. filter data browser, switch app, upload file) (parse-community#2014) chore(release): 4.0.0-beta.1 [skip ci] ci: release commit refactor: upgrade graphiql from 1.5.8 to 1.5.12 (parse-community#1971) refactor: upgrade otpauth from 7.0.7 to 7.0.8 (parse-community#1970) refactor: upgrade typescript from 4.4.4 to 4.5.2 (parse-community#1953) refactor: upgrade graphiql from 1.5.7 to 1.5.8 (parse-community#1968) ci: bump environment (parse-community#1966) refactor: upgrade graphiql from 1.5.5 to 1.5.7 (parse-community#1964) refactor: upgrade graphiql from 1.5.1 to 1.5.5 (parse-community#1963) chore(release): 4.0.0-alpha.5 [skip ci] fix: opening filter menu in data browser leads to blank page (parse-community#1958) refactor: upgrade graphql from 16.0.0 to 16.0.1 (parse-community#1955) refactor: use new React context API (parse-community#1948) refactor: use buttons instead of deprecated javascript URLs (parse-community#1940) refactor: upgrade webpack deps (parse-community#1939) chore(release): 4.0.0-alpha.4 [skip ci] ... # Conflicts: # package-lock.json # src/dashboard/Data/Jobs/JobEdit.react.js # src/dashboard/Data/Jobs/Jobs.react.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
state:released
Released as stable version
state:released-alpha
Released as alpha version
state:released-beta
Released as beta version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
This PR refactors the code that uses the legacy context API.
Related issue: #1950
Approach
contextTypes
properties and replace them withcontextType
class propertygeneratePath
to be a pure functionsubscribeTo
HOC to be a functional component to have better control when context (current app) changesTODOs before merging