feat: auto-submit one-time password (OTP) after entering #2257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
mtrezza
changed the title
mtrezza
changed the title
mtrezza
reviewed
Sep 9, 2022
mtrezza
requested changes
Sep 12, 2022
mtrezza
requested changes
Sep 12, 2022
|
Note for testing: This should work when entering digit by digit and when copy/pasting the whole code at once like from an auth app. |
mtrezza
reviewed
Sep 13, 2022
|
Is this ready for review? |
3 tasks
3 tasks
parseplatformorg
pushed a commit
that referenced
this pull request
Sep 14, 2022
# [4.2.0-alpha.12](4.2.0-alpha.11...4.2.0-alpha.12) (2022-09-14) ### Features * auto-submit one-time password (OTP) after entering ([#2257](#2257)) ([e528705](e528705))
|
🎉 This change has been released in version 4.2.0-alpha.12 |
parseplatformorg
pushed a commit
that referenced
this pull request
Sep 27, 2022
# [4.2.0-beta.2](4.2.0-beta.1...4.2.0-beta.2) (2022-09-27) ### Bug Fixes * column names in data browser menu not left-aligned ([#2263](#2263)) ([fc5673a](fc5673a)) * context menu in data browser is not scrollable ([#2271](#2271)) ([6c54bd8](6c54bd8)) * dashboard contains invalid html for top-level document ([#2254](#2254)) ([bbce857](bbce857)) * file upload dialog in data browser shows multiple times ([#2276](#2276)) ([3927340](3927340)) * login fails with error `req.session.regenerate is not a function` ([#2260](#2260)) ([1dc2b91](1dc2b91)) * unnecessary count operations in Data Browser ([#2250](#2250)) ([bfc1684](bfc1684)) * view relation dialog requires browser refresh when navigating ([#2275](#2275)) ([d60a8b7](d60a8b7)) ### Features * add column name to related records ([#2264](#2264)) ([cc82533](cc82533)) * add Node 18 support ([#2206](#2206)) ([bc7895a](bc7895a)) * add option to auto-sort columns alphabetically ([#2252](#2252)) ([2b7f20f](2b7f20f)) * apply filter in data browser by pressing "Enter" key ([#2256](#2256)) ([bc4f9eb](bc4f9eb)) * auto-submit one-time password (OTP) after entering ([#2257](#2257)) ([e528705](e528705)) * show skeleton as loading indicator in data browser while data is loading ([#2273](#2273)) ([059f616](059f616))
|
🎉 This change has been released in version 4.2.0-beta.2 |
parseplatformorg
pushed a commit
that referenced
this pull request
Oct 15, 2022
# [4.2.0](4.1.4...4.2.0) (2022-10-15) ### Bug Fixes * button text "Show all" in column menu is truncated ([#2208](#2208)) ([b89d044](b89d044)) * column names in data browser menu not left-aligned ([#2263](#2263)) ([fc5673a](fc5673a)) * context menu in data browser is not scrollable ([#2271](#2271)) ([6c54bd8](6c54bd8)) * dashboard contains invalid html for top-level document ([#2254](#2254)) ([bbce857](bbce857)) * file upload dialog in data browser shows multiple times ([#2276](#2276)) ([3927340](3927340)) * login fails with error `req.session.regenerate is not a function` ([#2195](#2195)) [skip release] ([31a2b78](31a2b78)) * login fails with error `req.session.regenerate is not a function` ([#2197](#2197)) [skip release] ([014d9c1](014d9c1)) * login fails with error `req.session.regenerate is not a function` ([#2260](#2260)) ([1dc2b91](1dc2b91)) * security upgrade terser from 5.10.0 to 5.14.2 ([#2222](#2222)) ([645cfdd](645cfdd)) * unnecessary count operations in Data Browser ([#2250](#2250)) ([bfc1684](bfc1684)) * view relation dialog requires browser refresh when navigating ([#2275](#2275)) ([d60a8b7](d60a8b7)) ### Features * add column name to related records ([#2264](#2264)) ([cc82533](cc82533)) * add Node 18 support ([#2206](#2206)) ([bc7895a](bc7895a)) * add option to auto-sort columns alphabetically ([#2252](#2252)) ([2b7f20f](2b7f20f)) * apply filter in data browser by pressing "Enter" key ([#2256](#2256)) ([bc4f9eb](bc4f9eb)) * auto-submit one-time password (OTP) after entering ([#2257](#2257)) ([e528705](e528705)) * improve button labels to be more concise in text ([#2207](#2207)) ([230fc14](230fc14)) * remove support and documentation links ([#2203](#2203)) ([35e4476](35e4476)) * show skeleton as loading indicator in data browser while data is loading ([#2273](#2273)) ([059f616](059f616))
|
🎉 This change has been released in version 4.2.0 |
beiguancyc
pushed a commit
to beiguancyc/parse-dashboard
that referenced
this pull request
Oct 20, 2022
* release: (74 commits) chore(release): 4.2.0 [skip ci] chore(release): 4.2.0-beta.2 [skip ci] chore(release): 4.2.0-alpha.17 [skip ci] fix: view relation dialog requires browser refresh when navigating (parse-community#2275) chore(release): 4.2.0-alpha.16 [skip ci] fix: file upload dialog in data browser shows multiple times (parse-community#2276) chore(release): 4.2.0-alpha.15 [skip ci] fix: context menu in data browser is not scrollable (parse-community#2271) chore(release): 4.2.0-alpha.14 [skip ci] feat: show skeleton as loading indicator in data browser while data is loading (parse-community#2273) chore(release): 4.2.0-alpha.13 [skip ci] feat: add column name to related records (parse-community#2264) refactor: bump scss-tokenizer and node-sass (parse-community#2267) ci: bump environment (parse-community#2266) chore(release): 4.2.0-alpha.12 [skip ci] feat: auto-submit one-time password (OTP) after entering (parse-community#2257) chore(release): 4.2.0-alpha.11 [skip ci] fix: column names in data browser menu not left-aligned (parse-community#2263) chore(release): 4.2.0-alpha.10 [skip ci] docs: add node 18 support badge to README ... # Conflicts: # package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
OTPs should autosubmit when they reach the required length
Related issue: #2164
Approach
The MFA algorithm doesn't currently store
digitsorperiod- this PR fixes that and passes digits to fronttend.TODOs before merging