-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: context menu in data browser is not scrollable #2271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request!
|
Does this work on touch UI? It's not a requirement, because there are UI elements in dashboard already that are not compatible with touch, but it would be nice to have. |
The context menu itself isn't compatible with touch UI as it requires a right click to show |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
# [4.2.0-alpha.15](4.2.0-alpha.14...4.2.0-alpha.15) (2022-09-19) ### Bug Fixes * context menu in data browser is not scrollable ([#2271](#2271)) ([6c54bd8](6c54bd8))
🎉 This change has been released in version 4.2.0-alpha.15 |
# [4.2.0-beta.2](4.2.0-beta.1...4.2.0-beta.2) (2022-09-27) ### Bug Fixes * column names in data browser menu not left-aligned ([#2263](#2263)) ([fc5673a](fc5673a)) * context menu in data browser is not scrollable ([#2271](#2271)) ([6c54bd8](6c54bd8)) * dashboard contains invalid html for top-level document ([#2254](#2254)) ([bbce857](bbce857)) * file upload dialog in data browser shows multiple times ([#2276](#2276)) ([3927340](3927340)) * login fails with error `req.session.regenerate is not a function` ([#2260](#2260)) ([1dc2b91](1dc2b91)) * unnecessary count operations in Data Browser ([#2250](#2250)) ([bfc1684](bfc1684)) * view relation dialog requires browser refresh when navigating ([#2275](#2275)) ([d60a8b7](d60a8b7)) ### Features * add column name to related records ([#2264](#2264)) ([cc82533](cc82533)) * add Node 18 support ([#2206](#2206)) ([bc7895a](bc7895a)) * add option to auto-sort columns alphabetically ([#2252](#2252)) ([2b7f20f](2b7f20f)) * apply filter in data browser by pressing "Enter" key ([#2256](#2256)) ([bc4f9eb](bc4f9eb)) * auto-submit one-time password (OTP) after entering ([#2257](#2257)) ([e528705](e528705)) * show skeleton as loading indicator in data browser while data is loading ([#2273](#2273)) ([059f616](059f616))
🎉 This change has been released in version 4.2.0-beta.2 |
# [4.2.0](4.1.4...4.2.0) (2022-10-15) ### Bug Fixes * button text "Show all" in column menu is truncated ([#2208](#2208)) ([b89d044](b89d044)) * column names in data browser menu not left-aligned ([#2263](#2263)) ([fc5673a](fc5673a)) * context menu in data browser is not scrollable ([#2271](#2271)) ([6c54bd8](6c54bd8)) * dashboard contains invalid html for top-level document ([#2254](#2254)) ([bbce857](bbce857)) * file upload dialog in data browser shows multiple times ([#2276](#2276)) ([3927340](3927340)) * login fails with error `req.session.regenerate is not a function` ([#2195](#2195)) [skip release] ([31a2b78](31a2b78)) * login fails with error `req.session.regenerate is not a function` ([#2197](#2197)) [skip release] ([014d9c1](014d9c1)) * login fails with error `req.session.regenerate is not a function` ([#2260](#2260)) ([1dc2b91](1dc2b91)) * security upgrade terser from 5.10.0 to 5.14.2 ([#2222](#2222)) ([645cfdd](645cfdd)) * unnecessary count operations in Data Browser ([#2250](#2250)) ([bfc1684](bfc1684)) * view relation dialog requires browser refresh when navigating ([#2275](#2275)) ([d60a8b7](d60a8b7)) ### Features * add column name to related records ([#2264](#2264)) ([cc82533](cc82533)) * add Node 18 support ([#2206](#2206)) ([bc7895a](bc7895a)) * add option to auto-sort columns alphabetically ([#2252](#2252)) ([2b7f20f](2b7f20f)) * apply filter in data browser by pressing "Enter" key ([#2256](#2256)) ([bc4f9eb](bc4f9eb)) * auto-submit one-time password (OTP) after entering ([#2257](#2257)) ([e528705](e528705)) * improve button labels to be more concise in text ([#2207](#2207)) ([230fc14](230fc14)) * remove support and documentation links ([#2203](#2203)) ([35e4476](35e4476)) * show skeleton as loading indicator in data browser while data is loading ([#2273](#2273)) ([059f616](059f616))
🎉 This change has been released in version 4.2.0 |
* release: (74 commits) chore(release): 4.2.0 [skip ci] chore(release): 4.2.0-beta.2 [skip ci] chore(release): 4.2.0-alpha.17 [skip ci] fix: view relation dialog requires browser refresh when navigating (parse-community#2275) chore(release): 4.2.0-alpha.16 [skip ci] fix: file upload dialog in data browser shows multiple times (parse-community#2276) chore(release): 4.2.0-alpha.15 [skip ci] fix: context menu in data browser is not scrollable (parse-community#2271) chore(release): 4.2.0-alpha.14 [skip ci] feat: show skeleton as loading indicator in data browser while data is loading (parse-community#2273) chore(release): 4.2.0-alpha.13 [skip ci] feat: add column name to related records (parse-community#2264) refactor: bump scss-tokenizer and node-sass (parse-community#2267) ci: bump environment (parse-community#2266) chore(release): 4.2.0-alpha.12 [skip ci] feat: auto-submit one-time password (OTP) after entering (parse-community#2257) chore(release): 4.2.0-alpha.11 [skip ci] fix: column names in data browser menu not left-aligned (parse-community#2263) chore(release): 4.2.0-alpha.10 [skip ci] docs: add node 18 support badge to README ... # Conflicts: # package-lock.json
New Pull Request Checklist
Issue Description
If there are too many related records, they can show off screen.
Related issue: #2265
Closes: #2265
Approach
Adds max height and overflow to context
TODOs before merging