fix: Prefetch for multiple info panels in data browser doesn't refresh stale cached data

[mtrezza]

New Pull Request Checklist

• I am not disclosing a vulnerability.
• I am creating this PR in reference to an issue.

Summary by CodeRabbit

• Performance Improvements
  • Enhanced batch navigation to rebuild object displays starting from selected items for faster updates
  • Implemented intelligent cache maintenance with timestamp-based cleanup
  • Optimized prefetch logic to reduce redundant data requests and improve responsiveness

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR enhances DataBrowser's batch navigation and prefetch caching logic. It adds timestamp-based cache maintenance to clean stale prefetch entries, introduces a needsPrefetch() helper to determine prefetch needs, and refactors the prefetch and batch display rebuild logic to validate cache validity before fetching.

Changes

Cohort / File(s)

Summary

Batch Navigation & Prefetch Logic src/dashboard/Data/Browser/DataBrowser.react.js

Enhanced batch display rebuild when selectedObjectId changes (now rebuilds when object not in batch or batch navigation enabled); added timestamp-based prefetch cache cleanup via Date.now(); introduced needsPrefetch() helper to determine if objects need prefetching based on cache presence or staleness; refactored prefetch flow to use needsPrefetch() in both single-panel and multi-panel scenarios; expanded handlePrefetch to validate cache before fetching main and batch-related objects.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

• Complexity drivers:

  • Dense logic changes affecting multiple code paths (batch rebuild, prefetch decision points, cache cleanup)
  • Interrelated concerns requiring understanding of batch navigation state, multi-panel display, and prefetch caching mechanics
  • Timestamp-based cache validation logic requires careful verification of staleness conditions
  • Two distinct prefetch paths (single-panel and multi-panel) with similar but separate logic

• Areas requiring extra attention:

  • needsPrefetch() helper logic and its application across different prefetch scenarios
  • Timestamp-based cache cleanup logic (when/how stale entries are removed)
  • Interaction between batch rebuild conditions and prefetch decisions
  • Multi-panel prefetch flow logic and batch teammate prefetch handling

Possibly related PRs

• fix: Info panel may show stale data of previous objects when refreshing the data table or navigating between classes #3036: Modifies the same file with related changes to selected/displayed object state and multiPanelData management, overlapping in batch rebuild and cache clearing logic
• fix: Info panel not refreshing on script execution #3040: Modifies DataBrowser.react.js with panel/display state and prefetch cache changes, particularly around displayedObjectIds reset and cache management
• feat: Add displaying multiple info panels and batch navigation #3020: Directly related evolution of multi-panel/batch-navigation state (panelCount, displayedObjectIds, batchNavigate) and batch-rebuild logic in the same component

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete. Only checklist items are marked, but critical sections like 'Issue Description', 'Approach', and 'TODOs before merging' are missing.	Add the 'Issue Description' section referencing the specific issue number, describe the approach taken, and specify any remaining TODOs before merge.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing prefetch behavior for multiple info panels to refresh stale cached data during batch navigation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/dashboard/Data/Browser/DataBrowser.react.js (1)

1387-1397: Consider simplifying needsPrefetch since stale entries are pre-cleaned.

The helper function is a good abstraction. However, since stale entries are already deleted in the cleanup loop above (lines 1376-1381), the stale check inside needsPrefetch (lines 1392-1395) will never evaluate to true—the stale entries no longer exist in cache by the time this helper is called.

This is defensively correct but slightly redundant. You could simplify to just check cache membership, or keep it as-is for future-proofing if the cleanup logic ever changes.

     const needsPrefetch = (objectId) => {
-      if (!Object.prototype.hasOwnProperty.call(cache, objectId)) {
-        return true;
-      }
-      if (prefetchStale) {
-        const entry = cache[objectId];
-        return entry && (now - entry.timestamp) / 1000 >= prefetchStale;
-      }
-      return false;
+      return !Object.prototype.hasOwnProperty.call(cache, objectId);
     };

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f335b2 and 91b6d81.

📒 Files selected for processing (1)

• src/dashboard/Data/Browser/DataBrowser.react.js (5 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-12-13T19:47:18.023Z

Learnt from: mtrezza
Repo: parse-community/parse-dashboard PR: 0
File: :0-0
Timestamp: 2025-12-13T19:47:18.023Z
Learning: In Parse Dashboard DataBrowser, the panel header context menu uses the hardcoded 'objectId' field when filtering scripts via `getValidScripts` because the panel header represents the entire object, not a specific field. Field-specific script execution happens when right-clicking on individual table cells in BrowserCell.

Applied to files:

• src/dashboard/Data/Browser/DataBrowser.react.js

📚 Learning: 2025-07-31T06:12:17.707Z

Learnt from: mtrezza
Repo: parse-community/parse-dashboard PR: 2957
File: src/dashboard/Data/Browser/BrowserTable.react.js:584-597
Timestamp: 2025-07-31T06:12:17.707Z
Learning: In Parse Dashboard's data browser selection logic (src/dashboard/Data/Browser/BrowserTable.react.js), the `selection['*']` pattern is used to handle global operations that pass `{ '*': true }` to indicate all items are selected, particularly for bulk operations like delete. This is not dead code but serves as compatibility layer for global operations that don't go through normal individual row selection workflows.

Applied to files:

• src/dashboard/Data/Browser/DataBrowser.react.js

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Docker linux/amd64

🔇 Additional comments (3)

src/dashboard/Data/Browser/DataBrowser.react.js (3)

960-964: LGTM! Clear optimization for batch navigation prefetch utilization.

The condition change ensures the batch is always rebuilt when batchNavigate is enabled, positioning the selected object at the start of the batch. This aligns with the navigation step size (jumping by panelCount) and enables proper utilization of prefetched data for subsequent batches.

---

1421-1423: Clean refactoring using the helper function.

Good use of the needsPrefetch helper to make the prefetch decision more readable and consistent with the batch object check below.

---

1430-1432: Consistent use of the helper for batch object prefetch decisions.

[parseplatformorg]

🎉 This change has been released in version 8.2.0-alpha.9