Skip to content

Add support for apns-priority key #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2019

Conversation

funkenstrahlen
Copy link
Contributor

This is already supported by node-apn framework but not yet exposed to be usable through this push adapter. It is now possible to set the priority for each notification.

When not set, node-apn uses a priority of 5 as default. This is the minimum value required for background notifications to be able to launch the app in background.

@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #128 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #128   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         259    262    +3     
=====================================
+ Hits          259    262    +3
Impacted Files Coverage Δ
src/APNS.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e84e8a...4ca61cc. Read the comment docs.

@parse-github-assistant
Copy link

The label type:feature cannot be used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants