Skip to content

Add support for apns-priority key #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Add support for apns-priority key #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b2e9dd
add support for apns-priority key
funkenstrahlen Jun 24, 2019
7296dda
Merge branch 'master' into apns-priority
acinader Jul 12, 2019
4ca61cc
Merge branch 'master' into apns-priority
dplewis Jul 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions spec/APNS.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,9 @@ describe('APNS', () => {
};
let expirationTime = 1454571491354;
let collapseId = "collapseIdentifier";
let priority = 5;

let notification = APNS._generateNotification(data, { expirationTime: expirationTime, collapseId: collapseId });
let notification = APNS._generateNotification(data, { expirationTime: expirationTime, collapseId: collapseId, priority: priority });

expect(notification.aps.alert).toEqual({ body: 'alert', title: 'title' });
expect(notification.aps.badge).toEqual(data.badge);
Expand All @@ -188,6 +189,7 @@ describe('APNS', () => {
});
expect(notification.expiry).toEqual(Math.round(expirationTime / 1000));
expect(notification.collapseId).toEqual(collapseId);
expect(notification.priority).toEqual(priority);
done();
});

Expand All @@ -208,11 +210,13 @@ describe('APNS', () => {
};
let expirationTime = 1454571491354;
let collapseId = "collapseIdentifier";
let priority = 5

let notification = APNS._generateNotification(data, { expirationTime: expirationTime, collapseId: collapseId });
let notification = APNS._generateNotification(data, { expirationTime: expirationTime, collapseId: collapseId, priority: priority });

expect(notification.expiry).toEqual(Math.round(expirationTime / 1000));
expect(notification.collapseId).toEqual(collapseId);
expect(notification.priority).toEqual(priority);

let stringifiedJSON = notification.compile();
let jsonObject = JSON.parse(stringifiedJSON);
Expand Down Expand Up @@ -283,6 +287,7 @@ describe('APNS', () => {
let data = {
'collapse_id': collapseId,
'expiration_time': expirationTime,
'priority': 6,
'data': {
'alert': 'alert'
}
Expand Down Expand Up @@ -313,6 +318,7 @@ describe('APNS', () => {
expect(notification.aps.alert).toEqual(data.data.alert);
expect(notification.expiry).toEqual(Math.round(data['expiration_time'] / 1000));
expect(notification.collapseId).toEqual(data['collapse_id']);
expect(notification.priority).toEqual(data['priority']);
let apnDevices = calledArgs[1];
expect(apnDevices.length).toEqual(4);
done();
Expand Down
9 changes: 7 additions & 2 deletions src/APNS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export class APNS {
let coreData = data.data;
let expirationTime = data['expiration_time'];
let collapseId = data['collapse_id'];
let priority = data['priority'];
let allPromises = [];

let devicesPerAppIdentifier = {};
Expand All @@ -96,7 +97,7 @@ export class APNS {
continue;
}

let headers = { expirationTime: expirationTime, topic: appIdentifier, collapseId: collapseId }
let headers = { expirationTime: expirationTime, topic: appIdentifier, collapseId: collapseId, priority: priority }
let notification = APNS._generateNotification(coreData, headers);
const deviceIds = devices.map(device => device.deviceToken);
let promise = this.sendThroughProvider(notification, deviceIds, providers);
Expand Down Expand Up @@ -166,7 +167,7 @@ export class APNS {
/**
* Generate the apns Notification from the data we get from api request.
* @param {Object} coreData The data field under api request body
* @param {Object} headers The header properties for the notification (topic, expirationTime, collapseId)
* @param {Object} headers The header properties for the notification (topic, expirationTime, collapseId, priority)
* @returns {Object} A apns Notification
*/
static _generateNotification(coreData, headers) {
Expand Down Expand Up @@ -214,6 +215,10 @@ export class APNS {
notification.topic = headers.topic;
notification.expiry = Math.round(headers.expirationTime / 1000);
notification.collapseId = headers.collapseId;
if (headers.priority) {
// if headers priority is not set 'node-apn' defaults it to 5 which is min. required value for background pushes to launch the app in background.
notification.priority = headers.priority
}
return notification;
}

Expand Down