Adds bcrypt native binding for better login performance #2549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Current coverage is 92.20% (diff: 100%)@@ master #2549 diff @@
==========================================
Files 97 97
Lines 11814 11817 +3
Methods 1454 1454
Messages 0 0
Branches 1906 1906
==========================================
+ Hits 10895 10896 +1
- Misses 919 921 +2
Partials 0 0
|
|
@flovilmart It's important that we use bcrypt native bindings for the compare function too. |
|
It's gonna be using it but the signature of the methods are the same, so no need to override the method |
| @@ -15,6 +14,21 @@ function hash(password) { | |||
| }); | |||
| } | |||
|
|
|||
| try { | |||
| bcrypt = require('bcrypt'); | |||
There was a problem hiding this comment.
here we override the bcrypt module altogether, so if it loads, the next bcrypt.compare will correctly call.
I had to do it that way for hash as both modules don't share the same signature.
|
@flovilmart updated the pull request - view changes |
|
@flovilmart updated the pull request - view changes |
caoer
added a commit
to caoer/parse-server
that referenced
this pull request
Aug 29, 2016
* ParsePlatform/master: (100 commits) Only allow basic auth credentials with a known appId (parse-community#2574) vk.com provider registered (parse-community#2579) chore(package): update parse-server-push-adapter to version 1.1.0 (parse-community#2588) vk.com auth data manager implemented (parse-community#2578) Fix a typo (parse-community#2563) Makes sure routes don't overlap and yield a header set error (parse-community#2559) Postgres: $all, $and CLP and more (parse-community#2551) Changelog 2.2.18 (parse-community#2558) chore(package): update winston-daily-rotate-file to version 1.3.0 (parse-community#2547) chore(package): update parse-server-s3-adapter to version 1.0.5 (parse-community#2536) Adds bcrypt native binding for better login performance (parse-community#2549) chore(package): update mongodb to version 2.2.7 (parse-community#2554) Make parse-server cloud code logging closer parse.com legacy (parse-community#2550) chore(package): update pg-promise to version 5.3.1 (parse-community#2519) Postgres: Operations, Hooks, OAuth login, Files support (parse-community#2528) Syncing afterSave/afterDelete trigger calls (Issue parse-community#2489) (parse-community#2499) Updated README.md (parse-community#2538) Fix capitalization, typo, and grammar mistake (parse-community#2533) Update ISSUE_TEMPLATE.md fix typo (parse-community#2525) ...
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2539