Makes sure routes don't overlap and yield a header set error #2559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Current coverage is 92.14% (diff: 100%)@@ master #2559 diff @@
==========================================
Files 97 97
Lines 11924 11927 +3
Methods 1457 1454 -3
Messages 0 0
Branches 1926 1929 +3
==========================================
+ Hits 10981 10990 +9
+ Misses 943 937 -6
Partials 0 0
|
|
Good catch! |
|
Are we sure we shouldn't instead avoid calling next() when we send a response? Seems like that is the standard way to handle overlapping routes. |
steven-supersolid
added a commit
to supersolid/parse-server
that referenced
this pull request
Aug 22, 2016
|
By not calling next, you prevent middlewares to run, and I will need it in a foreseeable future to cleanup caches or do other manipulations. This was added by @blacha because that helps with profiling time and logging responses which is a valid use case. |
bamwang
pushed a commit
to bamwang/parse-server
that referenced
this pull request
Aug 29, 2016
caoer
added a commit
to caoer/parse-server
that referenced
this pull request
Aug 29, 2016
* ParsePlatform/master: (100 commits) Only allow basic auth credentials with a known appId (parse-community#2574) vk.com provider registered (parse-community#2579) chore(package): update parse-server-push-adapter to version 1.1.0 (parse-community#2588) vk.com auth data manager implemented (parse-community#2578) Fix a typo (parse-community#2563) Makes sure routes don't overlap and yield a header set error (parse-community#2559) Postgres: $all, $and CLP and more (parse-community#2551) Changelog 2.2.18 (parse-community#2558) chore(package): update winston-daily-rotate-file to version 1.3.0 (parse-community#2547) chore(package): update parse-server-s3-adapter to version 1.0.5 (parse-community#2536) Adds bcrypt native binding for better login performance (parse-community#2549) chore(package): update mongodb to version 2.2.7 (parse-community#2554) Make parse-server cloud code logging closer parse.com legacy (parse-community#2550) chore(package): update pg-promise to version 5.3.1 (parse-community#2519) Postgres: Operations, Hooks, OAuth login, Files support (parse-community#2528) Syncing afterSave/afterDelete trigger calls (Issue parse-community#2489) (parse-community#2499) Updated README.md (parse-community#2538) Fix capitalization, typo, and grammar mistake (parse-community#2533) Update ISSUE_TEMPLATE.md fix typo (parse-community#2525) ...
shivangagarwal
pushed a commit
to sud80/parse-server
that referenced
this pull request
Aug 31, 2016
steven-supersolid
added a commit
to supersolid/parse-server
that referenced
this pull request
Aug 31, 2016
shivangagarwal
pushed a commit
to sud80/parse-server
that referenced
this pull request
Sep 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we call next on each promise resolution, the /me routes would then go into the /:objectId route, this PR makes sure both don't overlap