Skip to content

ci: add MongoDB 5 environment test #7806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Feb 12, 2022

New Pull Request Checklist

Issue Description

Parse Server 4.x is currently on LTS while Parse Server 5.0 is not officially released. MongoDB Atlas is force-upgrading lower cluster tiers to MongoDB 5.0 soon. Parse Server 4.x uses a MongoDB Node.js driver version that is officially incompatible with MongoDB 5.0. This PR adds a test to at run the CI with MongoDB 5 to see whether there are any obvious incompatibilities that should be addressed until Parse Server 5.0 is released.

Related issue: #n/a

Approach

Add MongoDB 5 env to CI tests.

TODOs before merging

  • Add tests

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-4.x.x@6f25ea9). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b0f16be differs from pull request most recent head a592a69. Consider uploading reports for the commit a592a69 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##             release-4.x.x    #7806   +/-   ##
================================================
  Coverage                 ?   84.09%           
================================================
  Files                    ?      169           
  Lines                    ?    12442           
  Branches                 ?        0           
================================================
  Hits                     ?    10463           
  Misses                   ?     1979           
  Partials                 ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f25ea9...a592a69. Read the comment docs.

@mtrezza
Copy link
Member Author

mtrezza commented Feb 12, 2022

To fix the failing MongoDB 5 tests, the fix in #7794 needs to ported to here.

mtrezza and others added 3 commits February 13, 2022 00:29
…arse-community#7794)

BREAKING CHANGE: The MongoDB GridStore adapter has been removed. By default, Parse Server already uses GridFS, so if you do not manually use the GridStore adapter, you can ignore this change.
@mtrezza mtrezza linked an issue Feb 17, 2022 that may be closed by this pull request
3 tasks
@olleolleolle
Copy link
Contributor

olleolleolle commented Feb 24, 2022

The "Mongo 4.0.4 ReplicaSet WiredTiger" failure seems to be about "a too-old Node.js version"?

Update: yeah, Installing Node 12.22.7 fixed it for me.

jsdom/whatwg-url#209 (comment)

Update: I saw that that update happened in mainline already.

@olleolleolle
Copy link
Contributor

Ah, @mtrezza perhaps this can be rebased on top of latest?

@mtrezza
Copy link
Member Author

mtrezza commented Mar 3, 2022

This is based on latest 4.x

@mtrezza mtrezza closed this Mar 24, 2022
@mtrezza mtrezza deleted the add-mongodb-5-ci branch March 24, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MongoDB 5.0 compatibility for Parse Server 4.x
3 participants