feat: Update config to automatically check types #8535
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
Thanks for opening this pull request! |
mtrezza
reviewed
May 17, 2023
| @@ -20,7 +20,7 @@ | |||
| * @property {Adapter<AnalyticsAdapter>} analyticsAdapter Adapter module for the analytics | |||
| * @property {String} appId Your Parse Application ID | |||
| * @property {String} appName Sets the app name | |||
| * @property {AuthAdapter[]} auth Configuration for your authentication providers, as stringified JSON. See http://docs.parseplatform.org/parse-server/guide/#oauth-and-3rd-party-authentication | |||
| * @property {Auth} auth Configuration for your authentication providers, as stringified JSON. See http://docs.parseplatform.org/parse-server/guide/#oauth-and-3rd-party-authentication | |||
There was a problem hiding this comment.
Could you give some insight about this change? It looks like a breaking change, or was the type incorrect?
There was a problem hiding this comment.
I think it's an incorrect type, the Auth option is not an array, it's an object with keys:
auth: {
facebook: {},
myAuth: {},
}There was a problem hiding this comment.
Could you please check:
- What do the docs (API docs and in
docsrepo) currently say - array or object? - Are there any tests that currently use an array, or do they all use an object?
- If a developer currently set an array instead of object, would Parse Server accept that option and would that actually work? If it works, will this change break an existing Parse Server where an array is set?
Just so we understand the full implications of this change / bug fix (?).
Signed-off-by: Daniel <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Parse Server options need to validated manually, where they should be compared directly against their
definitions.Closes: #8202
Approach
Tasks