-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add pre-compiled JavaScript artifacts for Perspective package #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 15 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
6b82083
use babel compiled assets rather than raw assets when building perspe…
LukeSheard 67fb588
correct output directory for babel and gitignore
LukeSheard 88eab9e
adjust core build entrypoints to account for the new asset location
LukeSheard 391e335
move webpack-plugin into separate package
LukeSheard 6422881
shift dependencies to where they're needed
LukeSheard fe67e4b
move core-js back to devDependencies
LukeSheard d6f48eb
make sure babel runs over code which is not precompiled during intern…
LukeSheard 4c7dba1
fix lint
LukeSheard a90bf0c
fix issues with importing babel config
LukeSheard 1b19470
fix issues with options validation
LukeSheard bf7c29e
update perspecrive package entrypoint
LukeSheard 6987434
fix jupyterlab build
LukeSheard 16adf83
fix lint
LukeSheard 3981ba8
undo cpp lint fix changes
LukeSheard 19b6362
undo less lint fix
LukeSheard 338ef31
fix perspective-viewer example and add cjs format into package
LukeSheard e03c7da
add commonjs build for viewer modules
LukeSheard 4316e77
remove unncessary loaders from jupyterlab plugin
LukeSheard 785cace
add viewer plugins into example
LukeSheard 8c22965
Merge branch 'master' into babel-compile
LukeSheard 5759d77
remove cross imports from modules
LukeSheard eb2b374
move loader code into webpack-plugin
LukeSheard 5644ba1
add parameters to webpack plugin to allow overriding options as a user
LukeSheard 5b69eb6
Apply default options in the correct order
LukeSheard 9de93af
tweak logic for CORS file loading in a webpack world
LukeSheard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| module.exports = { | ||
| "presets": [ | ||
| [ | ||
| "@babel/preset-env", | ||
| { | ||
| "useBuiltIns": "usage" | ||
| } | ||
| ] | ||
| ], | ||
| "sourceType": "unambiguous", | ||
| "plugins": [ | ||
| "module:fast-async", | ||
| ["@babel/plugin-proposal-decorators", {"legacy": true}], | ||
| "transform-custom-element-classes", | ||
| [ | ||
| "@babel/plugin-transform-for-of", | ||
| { | ||
| "loose": true | ||
| } | ||
| ] | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| module.exports = require("@jpmorganchase/perspective/webpack-plugin"); | ||
LukeSheard marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "name": "@jpmorganchase/perspective-webpack-plugin", | ||
| "version": "0.2.11", | ||
| "description": "Perspective.js Webpack Plugin", | ||
| "main": "index.js", | ||
| "publishConfig": { | ||
| "access": "public" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/jpmorganchase/perspective" | ||
| }, | ||
| "author": "", | ||
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "@jpmorganchase/perspective": "^0.2.11", | ||
| "@webpack-contrib/schema-utils": "^1.0.0-beta.0", | ||
| "file-loader": "^2.0.0", | ||
| "loader-utils": "^1.2.3", | ||
| "worker-loader": "^2.0.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "webpack": ">=3.5 <4" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,22 @@ | ||
| module.exports = { | ||
| presets: [ | ||
| "presets": [ | ||
| [ | ||
| "@babel/preset-env", | ||
| { | ||
| useBuiltIns: "usage" | ||
| "useBuiltIns": "usage" | ||
| } | ||
| ] | ||
| ], | ||
| sourceType: "unambiguous", | ||
| plugins: [ | ||
| "sourceType": "unambiguous", | ||
| "plugins": [ | ||
| "module:fast-async", | ||
| ["@babel/plugin-proposal-decorators", {legacy: true}], | ||
| ["@babel/plugin-proposal-decorators", {"legacy": true}], | ||
| "transform-custom-element-classes", | ||
| [ | ||
| "@babel/plugin-transform-for-of", | ||
| { | ||
| loose: true | ||
| "loose": true | ||
| } | ||
| ] | ||
| ] | ||
| }; | ||
| } |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.