Add pre-compiled JavaScript artifacts for Perspective package#378
Closed
LukeSheard wants to merge 25 commits intomasterfrom
Closed
Add pre-compiled JavaScript artifacts for Perspective package#378LukeSheard wants to merge 25 commits intomasterfrom
LukeSheard wants to merge 25 commits intomasterfrom
Conversation
Contributor
Author
|
@texodus any ideas why the https://travis-ci.org/jpmorganchase/perspective/jobs/478847521#L870 |
78362b6 to
16adf83
Compare
texodus
requested changes
Jan 18, 2019
Member
texodus
left a comment
There was a problem hiding this comment.
There seem to be some issues with this, notably that the example webpack project no longer compiles. Might I recommend fixing this example, which is both necessary and a good demonstration of what this refactor looks like from a consuming developer's standpoint?
texodus
reviewed
Jan 18, 2019
Contributor
Author
|
@texodus Updated the PR with all the comments we've discussed in person and on here. Still running into this issue when running the webpack example locally though: |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR does two things to enhance and improve the development workflow for apps running on the webpack plugin provided by
@jpmorganchase/perspective:@babel/cli). This reduces the overhead on webpack for end users since it doesn't need to run babel itself on every build for the package anymore.CJSmodule with it's dependencies externalised.