[WIP] Move webpack configuration to project root#382
[WIP] Move webpack configuration to project root#382ColinEberhardt wants to merge 1 commit intoperspective-dev:masterfrom
Conversation
|
@ColinEberhardt The webpack configs need to remain part of a package that's exported so that users can consume the API through webpack. Take a look at #378 which has a base for breaking these things out into a shared directory, we can make a private development package which is symlinked in but not published. |
I must admit, I'm not entirely sure what you mean! The APIs the Perspective currently exposes are the |
|
@LukeSheard is correct - Perspective requires a plugin to be used via webpack due to a few features which are tricky to configure correctly without carnal knowledge of the build, namely:
The implementation is based off Microsoft's Monaco webpack plugin, which has complications. All this aside though - I am unclear why the webpack configuration is the crux of your issues with As I don't believe this approach is going to work, I'm going to close this PR. If you feel this is in error, feel free to re-open or come over to the gitter channel where we can discuss. |
As per the discussion in this issue the focus workspaces features doesn't work at the moment because webpack configuration is part of the
@jpmorganchane\perspectivepackage.I think this configuration should be moved to the root of the project.
This PR illustrates the change for perspective-viewer only (hence it is a Work In Progress). I've simply taken the various webpack files and pasted them into
scripts\webpackWith these changes, the following now works:
If you're happy with this as an approach, I'll clean up and roll it out across the project.