Skip to content

Include various Improvements from the developer branch #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 11, 2019
Merged

Include various Improvements from the developer branch #17

merged 13 commits into from
Jun 11, 2019

Conversation

kMutagene
Copy link
Collaborator

  • Add Possibility to add a descriptive text below charts (thanks to @kkkmail)
  • Additional styling option for chart descriptions
  • Fix chart generation for docs (!future updates will need a new compilation of the custom FSharp.formatting!)
  • Fix size of svg container not set properly when using Chart.withSize
  • Add various marker symbols
  • add CI builds

fixes #9
closes #10

kkkmail and others added 13 commits December 25, 2018 11:01
@kkkmail
Added ShowWithDescription and ShowFileWithDescription
bd99364
@kMutagene
Fix docs:
a3616ae 
 - Add temporary helper functions to render charts for docs
 - Fix references and charts in all docs
 - add releaselocal target to test docs locally
@kMutagene
fix typos in docs
0d69703
@kMutagene
Add CI builds
1768bfc
@kMutagene
Add tryGetLayoutSize function to access the layout size of a GenericC…
fd81bb6 
…hart
@kMutagene
gitignore docs, do not ignore AssemblyInfo.fs
bb5bc2a
@kMutagene
fix gitignore
5c9c094
@kMutagene
Change toChartHTML to correctly set the size of the svg container whe…
4be2a7c 
…n specified by Chart.withSize
@kkkmail
Fix merge conflicts
1d45166
@kkkmail
Update ChartExtensions.fs
a42672b
@kMutagene
Merge pull request #15 from muehlhaus/kk-master
1d2891d 
Added ShowWithDescription and ShowFileWithDescription
@kMutagene
Add more styling options to optional Description text for charts
7e2e2bd
@kMutagene
Add various marker symbol styles
11a80f9
@kMutagene kMutagene requested a review from muehlhaus May 22, 2019 15:48
@kkkmail
Copy link
Contributor

kkkmail commented Jun 8, 2019

@muehlhaus , @kMutagene Do you have any comments about this PR? If not, I am going to merge it.

@muehlhaus muehlhaus merged commit 0dfae71 into master Jun 11, 2019
@muehlhaus
Copy link
Collaborator

@kkkmai Thank you. We will include a new plot feature within the next 2-3 days and make a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muehlhaus muehlhaus Awaiting requested review from muehlhaus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add functionality to provide textual description to the charts Chart size
3 participants
@kMutagene @kkkmail @muehlhaus