1.2.0 Release

[bkontur]

Please everyone leave a comment with a link to a pr or issue, so we have it tracked.

TODO

• PR with bump to polkadot@1.5 Upgrade to latest polkadot-sdk@1.5 release #137 (minimal configurations, just to compile)
• PR with bump to polkadot-sdk@1.6.0 Upgrade to latest polkadot-sdk@1.6 release #159
• PR with bump to polkadot-sdk@1.7.0 Upgrade to latest polkadot-sdk@1.7 release #187
• check/fix migrations when 1.1.0 / 1.1.2 deployed Removed migrations from tag v1.1.2 #195
• regenerate weights
  • regenerate weights for all pallets Update runtime weights for 1.2.0 #223
    • ping Upgrade to latest polkadot-sdk@1.7 release #187 (comment)
  • check bridge transfer fee constants
• bump spec_versions to 1_002_000 - done in Upgrade to latest polkadot-sdk@1.7 release #187
• check and bump transaction versions Check transaction_version for 1.2.0 Release for all runtimes #250
• check Nacho's integration tests
  • check/verify e2e tests: OpenGov -> relay to AssetHub - see comment @muharem
• fix #[api_version(7)] impl primitives::runtime_api::ParachainHost - fn node_features + verify what is missing bump ParachainHost to api version 9 #194
• add benchmark cumulus_pallet_parachain_system to SP runtimes
• address comment here
• integration tests improvement - adapt comment fixed by [tests] move to new xcm-emulator format & add P<>K emulated bridge tests #185

  # TODO: replace with `emulated-integration-tests-common@X.Y.Z` from `polkadot-sdk`
  integration-tests-common = { path = "../common" }
  

• remove unneeded dependencies (cargo machete)
• fix pallet_asset_conversion benchmarks [pallet-asset-conversion] Investigate benchmark swap_exact_tokens_for_tokens and MaxSwapPathLength paritytech/polkadot-sdk#3440
• Adds Snowbridge to Kusama and Polkadot Runtimes Adds Snowbridge to Kusama and Polkadot Runtimes #130

[bkchr]

• check try-runtime- [ ]

This is done by CI. Or what you mean?

[bkontur]

• check try-runtime- [ ]

This is done by CI. Or what you mean?

ok, cool, thank you, removed from desc

[h4x3rotab]

Was it intended to keep Polkadot runtime version and the Polkadot SDK version polkadot-vX.Y.Z?

Also, when do we expect 1.2.0 to rollout?

[bkontur]

@brenzi I am not touching encointer now, because iiuc, you need to release new versions of your crates with bumping them to polkadot-sdk@1.5 first, right? So , we can align encointer afterwards. If you need any help, just tell me.

# encointer deps
encointer-balances-tx-payment = { default-features = false, version = "3.0.2" }
encointer-balances-tx-payment-rpc-runtime-api = { default-features = false, version = "3.0.2" }
encointer-primitives = { default-features = false, version = "3.0.2" }
pallet-encointer-balances = { default-features = false, version = "3.0.2" }
pallet-encointer-bazaar = { default-features = false, version = "3.0.2" }
pallet-encointer-bazaar-rpc-runtime-api = { default-features = false, version = "3.0.2" }
pallet-encointer-ceremonies = { default-features = false, version = "3.0.2" }
pallet-encointer-ceremonies-rpc-runtime-api = { default-features = false, version = "3.0.2" }
pallet-encointer-communities = { default-features = false, version = "3.0.2" }
pallet-encointer-communities-rpc-runtime-api = { default-features = false, version = "3.0.2" }
pallet-encointer-faucet = { default-features = false, version = "3.0.2" }
pallet-encointer-reputation-commitments = { default-features = false, version = "3.0.2" }
pallet-encointer-scheduler = { default-features = false, version = "3.0.2" }

[brenzi]

@bkontur let me check. We'd like to be part of the next release and will do the necessary

[bkontur]

@bkontur let me check. We'd like to be part of the next release and will do the necessary

I guess, it is not a problem if you dont bump, encointer will just use old dependencies,
it is more about to be up-to-date with latest stuff and be aligned with other SP runtimes

[bkchr]

Was it intended to keep Polkadot runtime version and the Polkadot SDK version polkadot-vX.Y.Z?

I don't get the question?

Also, when do we expect 1.2.0 to rollout?

Probably earliest around end of february.

[brenzi]

it is more about to be up-to-date with latest stuff and be aligned with other SP runtimes

ok. do I get this right?:

• if we do nothing, the encointer runtime will automatically be part of the next release and the corresponding whitelisting/referendum with spec version 1001000
• if we upgrade dependencies, the spec version should be 1002000

[nanometerzhu]

I don't get the question?

I think @h4x3rotab 's question is, even both polkadot-sdk and runtimes have same version format X.Y.Z, but looks like the numbers are different:

• runtime v1.0.0 -> polkadot-sdk v1.0.0
• runtime v1.1.0 -> polkadot-sdk v1.3.0
• runtime v1.2.0 -> polkadot-sdk v1.5.0

Is this unmatched a intended behavior? Is it possible to use same version number so the downstream teams can easier to track?

[bkchr]

Is this unmatched a intended behavior?

Yes, fellowship is not following the release schedule etc of the polkadot-sdk repo. Most of the time the fellowship releases also include multiple polkadot-sdk releases.

Is it possible to use same version number so the downstream teams can easier to track?

If required, we could probably track this in the CHANGELOG file.

[eskimor]

What is the timeline? Can we get coretime in, if everything is ready this week? We need two more PRs which are waiting for audit, so we would need to bump the polkadot-sdk release as well.

[bkchr]

We don't need audits for Kusama.

But I also think, that we can wait for the next polkadot-sdk release in two weeks.

[liamaharon]

Can we include #122 in this release?

[bkontur]

Can we include #122 in this release?

@liamaharon could this locks migration be related to the error bellow:

for Kusama: https://github.com/polkadot-fellows/runtimes/actions/runs/7553599023/job/20564716882?pr=137

[2024-01-17T09:42:37Z ERROR runtime::executive] - 0. error: Failed to decode storage item `Balances::Locks`
[2024-01-17T09:42:37Z ERROR runtime::executive] - 1. error: Failed to decode storage item `Session::NextKeys`

unrelated to locks for Polkadot: https://github.com/polkadot-fellows/runtimes/actions/runs/7553599023/job/20564716569?pr=137

[2024-01-17T09:46:25Z ERROR runtime::executive] - 0. error: Failed to decode storage item `Proxy::Proxies`

[liamaharon]

Yep, this should fix that unable to decode locks issue.

Not sure why Session::NextKeys is still broken on Kusama... I recall it is supposed to fix after a runtime upgrade, hopefully it self-resolves (@bkchr was that right?)

Proxy::Proxies failing on Polkadot is a new one :') Created an issue, hopefully can fix this week #145