Upgrade to latest `polkadot-sdk@1.5` release by bkontur · Pull Request #137 · polkadot-fellows/runtimes

bkontur · 2024-01-09T11:28:26Z

Attached result of cargo upgrade -v --pinned --incompatible cargo-upgrade-version-bump.log

E.g.: frame-support from 25.0.0 to 27.0.0

Note: Encointer was not upgraded (because its pallet references polkadot@1.3.0 release).

TODO

fix compilation
fix integration tests
fix benchmarks (also try them)
patch for pallet-nomination-pools migration fix Backport of fix Pools 6->7 migration (#2942) paritytech/polkadot-sdk#3094
patch for xcm-executor fix Backport XCM fixes to 1.5.0 paritytech/polkadot-sdk#3174
- search for TODO:(PR#137) - wait for xcm-executor patch (missing FrameTransactionalProcessor)
check/verify MaxExposurePageSize = 512 / MaxNominators = 512 for Kusama/Polkadot
- check with SRLabs (Jakob) https://github.com/paritytech-secops/srlabs_findings/issues/327

Closes: #113

bkontur · 2024-01-13T00:02:22Z

@bkchr @ggwpez guys, any idea what is wrong here?

error: failed to run custom build command for `asset-hub-kusama-runtime v1.0.0 (/home/runner/work/runtimes/runtimes/system-parachains/asset-hubs/asset-hub-kusama)`
Caused by:
  process didn't exit successfully: `/home/runner/work/runtimes/runtimes/target/release/build/asset-hub-kusama-runtime-c709c9b8e18d4c08/build-script-build` (exit status: 1)
  --- stderr
  Cannot compile the WASM runtime: no standard library sources found!
  You can install them with `rustup component add rust-src` if you're using `rustup`.
warning: build failed, waiting for other jobs to finish...
error: failed to run custom build command for `bridge-hub-kusama-runtime v1.0.0 (/home/runner/work/runtimes/runtimes/system-parachains/bridge-hubs/bridge-hub-kusama)`
Caused by:
  process didn't exit successfully: `/home/runner/work/runtimes/runtimes/target/release/build/bridge-hub-kusama-runtime-c9ab234e71cf4721/build-script-build` (exit status: 1)
  --- stderr
  Cannot compile the WASM runtime: no standard library sources found!
  You can install them with `rustup component add rust-src` if you're using `rustup`.
Error: Process completed with exit code 101.

I just see that this error message is coming from here.

I thought it is related to the Fetch cache step error:

Warning: Error parsing Cargo.toml manifest, fallback to caching entire file: Error: Invalid TOML document: expected key-value, found comma

123:  serde_json = "1.0.111"
124:  remote-externalities = { package = "frame-remote-externalities" , version = "0.34.0" }

but it is not.

Locally it works (I know, I know...), maybe I missed something to port, will investigate Monday.

bkchr · 2024-01-13T00:17:21Z

@bkontur change the stable toolchain installation to use the default profile. We need rust-src to be installed.

bkontur · 2024-01-13T08:41:21Z

@bkontur change the stable toolchain installation to use the default profile. We need rust-src to be installed.

@bkchr ok, cool, thank you, back in the game, just adding rust-src to stable components with minimal profile works.

ggwpez · 2024-01-13T12:33:15Z

I thought it is related to the Fetch cache step error:

It should fix on the next update: Swatinem/rust-cache#172 (comment)

bkontur · 2024-01-15T15:30:21Z

@ggwpez should we add DMP migrations (UndeployDmpQueue, DeleteDmpQueue) from here also?

ggwpez · 2024-01-16T10:39:00Z

@ggwpez should we add DMP migrations (UndeployDmpQueue, DeleteDmpQueue) from here also?

Its a two step process, first we do a runtime upgrade without them and then in the next one we add these migrations to delete the DmpQueue.
It is also not critical if it happens later since the pallet is already defunc.
PS: I cant find those migrations in the code-base 😅 wtf

Ank4n · 2024-01-17T02:28:16Z

pallet-staking bump >= 26 will introduce a paged exposure feature that will break some dapps if they have not integrated the changes. Is it possible to upgrade only Kusama and have it running only on Kusama for a while before upgrading Polkadot? cc: @jakoblell

https://forum.polkadot.network/t/staking-update-paged-staking-reward-to-avoid-validator-oversubscription-issue-is-live-on-westend/5215

This should result as a patched `24.0.1` version for https://crates.io/crates/pallet-nomination-pools/24.0.0. Relates to: polkadot-fellows/runtimes#137 --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: PG Herveou <pgherveou@gmail.com>

This is a cherry-pick of #3094 (patch to `release-polkadot-v1.5.0`). This should result as a patched `24.0.1` version for https://crates.io/crates/pallet-nomination-pools/24.0.0. Relates to: polkadot-fellows/runtimes#137 --------- --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: PG Herveou <pgherveou@gmail.com> Co-authored-by: command-bot <>

…-1.5 # Conflicts: # Cargo.lock

bkontur · 2024-02-13T15:10:41Z

Fellows, please review this bump.

The only thing missing is the failed check-migrations (Polkadot) job, but this will be automatically resolved when Polkadot@1.1.2 is enacted on February 19: link to referendum.

muharem · 2024-02-14T03:26:06Z

 				.iter()
 				.cloned()
-				.map(|k| (k, ASSET_HUB_POLKADOT_ED * 4096))
+				.map(|k| (k, ASSET_HUB_POLKADOT_ED * 4096 * 4096))


intentional increase?

These are just genesis configs for testing, so changing them is fine.

yes, but still might affect tests, wanted to point in case of accidental change

muharem · 2024-02-14T03:57:46Z

+	);
+}
+
+// TODO: Encointer pallets does not have compatible `polkadot-sdk` versions,


it can be very easy to forget to update this when something updated in constants. may be we should try to drop some dependancies from constant crates. Should we have at least an issue for thus?

…-1.5

Based on bump to [`polkadot-sdk@1.5.0`](#137). Attached result of `cargo upgrade -v --pinned --incompatible` [cargo-upgrade-version-bump.log](https://github.com/polkadot-fellows/runtimes/files/14044160/cargo-upgrade-version-bump.log) _Note: Encointer was not upgraded (because its pallet references `polkadot@1.3.0` release)._ ## ~~For reviewers~~ ~~This PR is against `polkadot-fellows`'s main to bring it to the fellows repo, but if you want to see a real diff relevant to the `polkadot-sdk@1.6.0` update please check: bkontur/runtimes@bko-bump-to-1.5...bkontur:runtimes:bko-bump-to-1.6.~~ ## TODO - [x] fix compilation - [x] fix integration tests - [x] fix benchmarks (also try them) - `collectives-polkadot` `payout` - [ ] ~~Does not require a CHANGELOG entry~~ - [x] `warning: use of deprecated struct `staging_xcm_builder::CurrencyAdapter`: Use `FungibleAdapter` instead` - [ ] search for `TODO:(PR#159) change to FungibleAdapter` and/or wait for paritytech/polkadot-sdk#3287 - [x] patch for `pallet-nomination-pools` migration fix paritytech/polkadot-sdk#3093 - will be fixed here #188 (comment) - [x] patch for `xcm-executor` fix (for 1.6.0) e.g. paritytech/polkadot-sdk#3174 - [x] check/fix coretime stuff for Kusama/Polkadot - search for `// TODO:(PR#159)(PR#1694)` - see [comment](#159 (comment)) - fixed by bkontur#3 - [x] check the `MaxControllersInDeprecationBatch`https://github.com/polkadot-fellows/runtimes/pull/159/files#r1492361038 - [x] check `pallet_identity::Config` for Kusama and Polkadot https://github.com/polkadot-fellows/runtimes/pull/159/files#r1492363866 --------- Signed-off-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Ross Bulat <ross@parity.io> Co-authored-by: Alain Brenzikofer <alain@integritee.network> Co-authored-by: eskimor <eskimor@no-such-url.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>

…chain (#174) This PR does two things: 1) (tiny refactoring) adds `TRANSACTION_BYTE_FEE` constant to `system-parachains-constants` crate. We are using the same value (`1 * MILLICENTS`) across all chains, so it makes sense to move it there; 2) changes default value of governance-controlled `XcmBridgeHubRouterByteFee` constant (which is used to cover the cost of message delivery within the remote consensus) to use `TRANSACTION_BYTE_FEE` of the bridged chain (also does 1:5/5:1 conversion). Since governance has not set value of this constant yet, we are changing the default value here, in the code. ~The failing test is fixed by the #137, so it makes sense to merge this PR only after #137~ Updated --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

@vgeddes

- [x] Adds asset hub and bridge hub to Kusama and Polkadot runtimes - [x] based off #108 - needs to be merged first - [x] snowbridge crates needs to be published on crates.io - depends on `polkadot-sdk 1.7.0` - [x] MessageQueue Pallet is not configured on Kusama and Polkadot asset hub - added in #137 - [x] `FeeManager` `handle_fee` misses reason, crate needs to be updated I think cc @vgeddes @alistair-singh @yrong @musnit --------- Signed-off-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Ross Bulat <ross@parity.io> Co-authored-by: claravanstaden <Cats 4 life!> Co-authored-by: Alain Brenzikofer <alain@integritee.network> Co-authored-by: eskimor <eskimor@no-such-url.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: brenzi <brenzi@users.noreply.github.com> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: ron <yrong1997@gmail.com> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: Vincent Geddes <vincent.geddes@hey.com>

bkontur mentioned this pull request Jan 9, 2024

single PR on polkadot-sdk version update #101

Open

bkontur force-pushed the bko-bump-to-1.5 branch 3 times, most recently from 99b2457 to 2203e3f Compare January 9, 2024 15:18

ggwpez mentioned this pull request Jan 9, 2024

The versions of the primitive packages are not synced with crates.io paritytech/polkadot-sdk#2809

Open

2 tasks

bkontur force-pushed the bko-bump-to-1.5 branch 3 times, most recently from 67fad4f to 889cb10 Compare January 10, 2024 11:39

bkontur mentioned this pull request Jan 10, 2024

1.2.0 Release #140

Closed

19 tasks

bkontur force-pushed the bko-bump-to-1.5 branch 4 times, most recently from 6eb085d to 288bc02 Compare January 11, 2024 11:27

bkontur mentioned this pull request Jan 11, 2024

Add integration xcm-emulator tests for bridge-hubs to K/P bridging in fellows repo paritytech/parity-bridges-common#2791

Closed

bkontur force-pushed the bko-bump-to-1.5 branch 3 times, most recently from d4aac62 to 77ae24a Compare January 12, 2024 21:27

bkontur force-pushed the bko-bump-to-1.5 branch from dae97a5 to 76ac2f3 Compare January 13, 2024 08:32

ggwpez approved these changes Jan 13, 2024

View reviewed changes

Comment thread relay/kusama/src/lib.rs

Comment thread relay/kusama/src/lib.rs

Comment thread relay/polkadot/src/lib.rs

Comment thread system-parachains/bridge-hubs/bridge-hub-kusama/src/bridge_to_polkadot_config.rs

ggwpez self-requested a review January 13, 2024 13:52

bkontur force-pushed the bko-bump-to-1.5 branch 2 times, most recently from 69b9a5e to 01953fd Compare January 14, 2024 22:42

bkontur mentioned this pull request Jan 15, 2024

Introduce chain-spec-generator and document Weight Generation process #127

Merged

2 tasks

bkontur mentioned this pull request Feb 6, 2024

Backport of fix Pools 6->7 migration (#2942) (#3094) paritytech/polkadot-sdk#3220

Merged

[bridges] Changed order/index for MessageQueue on BridgeHubs

7fc05c1

bkontur mentioned this pull request Feb 7, 2024

Snowbridge - bump polkadot-fellows to 1.4 / 1.5 / 1.6 / 1.7 upcoming-1.6-with-snowbridge subtree paritytech/parity-bridges-common#2775

Closed

8 tasks

bkontur added 5 commits February 12, 2024 15:37

Finally patched pallet-nomination-pools + removed tmp migration

3e55fe6

Finally patched pallet-nomination-pools + removed tmp migration

288f0a1

[xcm-executor/builder] Patch with transactional fix

c6b16fa

Fix patch for penpal-runtime

975c08d

Merge remote-tracking branch 'polkadot-fellows/main' into bko-bump-to…

be53230

…-1.5 # Conflicts: # Cargo.lock

This was referenced Feb 13, 2024

[nomination-pools] Backwards fix for post_upgrade migration V6ToV7 paritytech/polkadot-sdk#3305

Closed

[nomination-pools] Backwards fix for post_upgrade migration V6ToV7 paritytech/polkadot-sdk#3306

Closed

[collectives] Removed older TODOs - addresing polkadot-fellows#113

e7dffea

muharem approved these changes Feb 14, 2024

View reviewed changes

bkchr approved these changes Feb 14, 2024

View reviewed changes

Comment thread system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs

bkontur mentioned this pull request Feb 14, 2024

1.3.0 Release #186

Closed

9 tasks

Updated TODO for removing DMPQueue

97f81f9

andresilva approved these changes Feb 14, 2024

View reviewed changes

acatangiu approved these changes Feb 14, 2024

View reviewed changes

acatangiu reviewed Feb 14, 2024

View reviewed changes

Comment thread system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs

bkontur added 3 commits February 14, 2024 14:59

[collectives-polkadot] Fixed benchmarks (expcept payout)

01d2344

Merge remote-tracking branch 'polkadot-fellows/main' into bko-bump-to…

73af5ea

…-1.5

[bridges] Added code comment for MessageExportPrice

f82cc05

bkchr merged commit e5a723f into polkadot-fellows:main Feb 14, 2024

bkontur deleted the bko-bump-to-1.5 branch February 14, 2024 15:16

liamaharon mentioned this pull request Feb 15, 2024

Undecodable nomination-pool state after after upgrading to polkadot-sdk@1.5 #188

Closed

Conversation

bkontur commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

bkontur commented Jan 13, 2024

Uh oh!

bkchr commented Jan 13, 2024

Uh oh!

bkontur commented Jan 13, 2024

Uh oh!

ggwpez commented Jan 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkontur commented Jan 15, 2024

Uh oh!

ggwpez commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ank4n commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkontur commented Feb 13, 2024

Uh oh!

muharem Feb 14, 2024

Choose a reason for hiding this comment

Uh oh!

bkchr Feb 14, 2024

Choose a reason for hiding this comment

Uh oh!

muharem Feb 15, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

muharem Feb 14, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

bkontur commented Jan 9, 2024 •

edited

Loading

ggwpez commented Jan 16, 2024 •

edited

Loading

Ank4n commented Jan 17, 2024 •

edited

Loading