Skip to content

Wrap bare value box value in p tags #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 10, 2023
Merged

Wrap bare value box value in p tags #668

merged 4 commits into from
Aug 10, 2023

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 8, 2023 •
edited
Loading

Fixes #646

  • Changelog entry

@schloerke schloerke self-assigned this Aug 8, 2023
@schloerke schloerke marked this pull request as ready for review August 8, 2023 18:19
@schloerke schloerke requested a review from wch August 8, 2023 18:20
@schloerke
Merge branch 'main' into fix_valuebox_typo
f592ced 
* main:
  Use a renderer generator to create sync/async render methods with full typing (#621)
  docs: Add Tooltip section in experimental (#673)
  Bump version to 0.5.1
  Add missing sidebar stylesheet dep (#667)
@schloerke
Copy link
Collaborator Author

Failing test is related to #675 (and is unrelated to this PR).

Merging

@schloerke schloerke merged commit 29c1752 into main Aug 10, 2023
@schloerke schloerke deleted the fix_valuebox_typo branch August 10, 2023 19:53
schloerke added a commit that referenced this pull request Aug 22, 2023
@schloerke
Merge branch 'main' into pop_over
57fae0b 
* main:
  feat(Session): Make Session on_flush() and on_flushed() accept async functions (#693)
  Make data frame selection return row numbers, not pandas index value (#677)
  chore(api)!: Rename `ui.navset_pill_card` -> `ui.navset_card_pill` and `ui.navset_tab_card` -> `ui.navset_card_tab` (#681)
  Consolidate all testing into `tests/` folder (#683)
  Fix pyright error (#678)
  Make model score app work on Connect/Shinyapps.io (#657)
  Suppress type check for read_csv
  Synchonize input_file examples
  More realistic file import example (#582)
  Make flaky dataframe test have larger timeout (#675)
  Wrap bare value box value in `p` tag (#668)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch Awaiting requested review from wch

Assignees

@schloerke schloerke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

value_box value is too small
1 participant
@schloerke