Skip to content

Fix pyright error #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Fix pyright error #678

merged 3 commits into from
Aug 15, 2023

Conversation

jcheng5
Copy link
Collaborator

@jcheng5 jcheng5 commented Aug 15, 2023

Seems to have been introduce by new pandas type stubs (2.0.3)

Seems to have been introduce by new pandas type stubs?
@jcheng5 jcheng5 requested a review from wch August 15, 2023 02:27
@wch
Copy link
Collaborator

wch commented Aug 15, 2023

Thanks. Can you also update shiny/api-examples/input_file/app.py ? It has the same contents as shiny/examples/input_file/app.py.

@jcheng5
Copy link
Collaborator Author

jcheng5 commented Aug 15, 2023

Oh, wait, wait. shiny/examples/input_file shouldn't exist. If we want to make it a top-level example, it should be examples/input_file. (Do we?)

@jcheng5 jcheng5 merged commit 4bcd529 into main Aug 15, 2023
@jcheng5 jcheng5 deleted the fix-index-unknown branch August 15, 2023 19:04
schloerke added a commit that referenced this pull request Aug 22, 2023
* main:
  feat(Session): Make Session on_flush() and on_flushed() accept async functions (#693)
  Make data frame selection return row numbers, not pandas index value (#677)
  chore(api)!: Rename `ui.navset_pill_card` -> `ui.navset_card_pill` and `ui.navset_tab_card` -> `ui.navset_card_tab` (#681)
  Consolidate all testing into `tests/` folder (#683)
  Fix pyright error (#678)
  Make model score app work on Connect/Shinyapps.io (#657)
  Suppress type check for read_csv
  Synchonize input_file examples
  More realistic file import example (#582)
  Make flaky dataframe test have larger timeout (#675)
  Wrap bare value box value in `p` tag (#668)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants