Skip to content

Fix pyright error #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Fix pyright error #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
336e8d8
Fix pyright error
jcheng5 Aug 15, 2023
3dcc6a6
Fix pyright error in input_file app
jcheng5 Aug 15, 2023
bf01f65
Remove shiny/examples; it was renamed to shiny/api-examples
jcheng5 Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 0 additions & 56 deletions shiny/examples/input_file/app.py
View file
Open in desktop

This file was deleted.

5 changes: 4 additions & 1 deletion shiny/plotutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,10 @@ def brushed_points(
use_y = "y" in brush["direction"]

# Filter out x and y values
keep_rows: pd.Series[bool] = pd.Series(True, index=new_df.index)
keep_rows: pd.Series[bool] = pd.Series(
True,
index=new_df.index, # pyright: ignore[reportUnknownMemberType]
)
if use_x:
if xvar is None and "x" in brush["mapping"]:
xvar = brush["mapping"]["x"]
Expand Down