-
Notifications
You must be signed in to change notification settings - Fork 482
Update to 2.4, add PostgreSQL 10 #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… postgis, so the 2.4 versions of pgsql2shp, shp2pgsql, raster2pgsql, and shp2pgsql-gui are installed.
@@ -8,7 +8,7 @@ RUN apt-get update \ | |||
&& apt-get install -y --no-install-recommends \ | |||
postgresql-$PG_MAJOR-postgis-$POSTGIS_MAJOR=$POSTGIS_VERSION \ | |||
postgresql-$PG_MAJOR-postgis-$POSTGIS_MAJOR-scripts=$POSTGIS_VERSION \ | |||
postgis=$POSTGIS_VERSION \ | |||
postgis\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put the space back: postgis \
@@ -15,6 +16,7 @@ env: | |||
- VERSION=9.3-2.3 VARIANT=alpine | |||
- VERSION=9.2-2.3 | |||
- VERSION=9.2-2.3 VARIANT=alpine | |||
- VERSION=10-2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about Alpine variants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm taking a stab at updating this myself (assuming you didn't uncheck the checkbox that lets me push to your branch).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, Allow edits from maintainers
is still checked
Due to the problem that the postgis package is not versioned with a release number in the name (see here), the version constraint for the postgis package (which contains the
pgsql2shp
,shp2pgsql
,raster2pgsql
, andshp2pgsql-gui
userland binaries)o. The 9.x-2.3 images thus have postgis 2.3 installed, but these binaries are from postgis 2.4Fixes #62