Closed
Conversation
Closed
added 3 commits
October 13, 2017 09:58
…able and it doesn't seem to break anything. Postgis is still installed with postgresql-9.6-postgis-2.3
… postgresl-10 is `FROM debian:stretch`
tdamsma
changed the title
md5
reviewed
Oct 13, 2017
| && apt-get install -y --no-install-recommends \ | ||
| postgresql-$PG_MAJOR-postgis-$POSTGIS_MAJOR=$POSTGIS_VERSION \ | ||
| postgresql-$PG_MAJOR-postgis-$POSTGIS_MAJOR-scripts=$POSTGIS_VERSION \ | ||
| postgis=$POSTGIS_VERSION \ |
Contributor
There was a problem hiding this comment.
Can we discuss this removal? I know they don't version this package name, so is the issue that only the 2.4 version is now available? If so, then I'd like to remove 2.3 entirely.
Contributor
Contributor
|
Can you squash your commits? I think it would make sense to see a single commit for the 2.3 package upgrades (assuming we don't remove 2.3), another commit for adding the 2.4 images, and another commit for the updates to |
Author
|
That would indeed make perfect sense, but my git-fu is lacking a bit. You could also just squash-merge the whole bunch, as the updates are a bit related: I didn't want to update the 2.3 images, but I had to cause they used outdated packages. Anyways, I'll give it a shot |
Author
|
Resubmitted as #64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added postgresql 10 + postgis 2.4.0, and postgresql 9.6 + postgis 2.4.0.
To get the postgis 2.3 builds passing, I had to remove line 11
postgis=$POSTGIS_VERSION \from the template, as postgis 2.3 has been purged from the apt repo. I don't understand why postgis needs to be installed after postgresql-x-postgis-x is installed before, everything seem to just work without it. But as I don't understand why it was there, I can't really judge if it is a bad idea to remove it.As postgresl-10 is
FROM debian:stretch, I modified the update script to take that into account