-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add saved beatmap filter functionality with popover UI #35991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This is amazing and will definitely be used by a lot of players IF it's obvious enough. I suggest to change that search icon's design/color a bit so that it can stick out a bit more on the naked eye and have more players be aware of this feature. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Why does clicking a filter keep the menu open while deleting closes it? A starting point would be to use existing design cues rather than make something completely new feeling. Maybe the collections dropdown is a good place to start? It matches design language and also features a custom button. |
|
I tried adding a new drop-down menu next to collections, but it took up too much horizontal space and made the header too cluttered, so I placed the control in the search button instead. In addition, the collections drop-down menu uses a slanted layout and darker colours, so rather than using this visual in the search area, I made a variation that I think fits better with the search visual. |
|
As long as it's in the filter control, I believe you need to match the skew. It doesn't have to be an actual dropdown, but should be styled to fit. |
|
Deleting a saved filter now keeps the menu open, and the menu is slanted to better match the current style. video2.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't follow other popover button state behavior (i.e. pressing down the button should close the popover and pressing up should open it again). Should be consistent even if I find the behavior weird as many others in the below discussion have.
Ref: #33387
|
The behavior when pressing the button is now the same as other popovers video3.mp4 |
Add the ability to save and re-apply beatmap selection filters in Song Select (SelectV2). It introduces a small popover UI accessible from the search box area, allowing users to:
Related discussions: #30403, #13010
video2.mp4
This is my first contribution to this repository and also my first experience with C#. Thanks in advance for your time and feedback!