How to unregister / remove any registered service workers?

[robinvdvleuten]

Is it possible to remove any registered service workers by this CLI for any visitors on a production app? The application runs currently with the precache sw.js and I would like to have it removed. I understand that I can do it myself with the console tools, but I can't let my users do the same.

[prateekbh]

sadly this line prevent you from doing so
https://github.com/developit/preact-cli/blob/19067c7091b463b2a70b319e87d15037880b4fbc/src/lib/entry.js#L7

although I guess I can add a quick solution to this, will try to add a flag.
@reznord u think a flag ``--no-pwa` should be a good solution here? if yes, you'd need to add in you interactive stuff as well

[reznord]

a flag ``--no-pwa` should be a good solution here
This defies the whole purpose of preact-cli.

But still we can unregister a service worker which makes sense (I still have to try it out).

[prateekbh]

This defies the whole purpose of preact-cli.

It shouldn't right? not sure if everything needs to be a Offline ready or have SW behind it. e.g. a documentation of a project. or for what ever reason @robinvdvleuten wants it.

preact-cli is the cli for building preact web apps. PWA preferred but not necessary

[robinvdvleuten]

I use it indeed mainly to prevent myself from spending a couple of hours on a decent webpack setup. The preact-cli project gets me starting quickly on any prototype I would like to make. It would be very nice if it's possible to opt-out yourself from the PWA when generating a new project, but it would also be very nice to be able to opt-out in any later stages of your project.

The CRA has a similar setup. But it feels like I have more control over the service-worker registration process. The preact-cli just generates it and I am never able to unregister it again.

[prateekbh]

opt-out/opt-in can be controlled by a build step flag at anytime

[reznord]

makes sense to me.

@developit @lukeed what do you think about this?

[prateekbh]

@developit @lukeed @reznord lemme know if the approach makes sense, m up to send this PR

[developit]

Should we use a more specific flag like --no-sw ?

[reznord]

That makes sense! This should be only for the build step right?

[lukeed]

Same idea, but what about --no-offline?

[prateekbh]

well --no-offline can be achieved using preact-cli-sw-precache-plugin by giving empty array for precache, the problem is for not being able to add sw.js

[robinvdvleuten]

It would also be nice if you're able to opt-out of the sw.js if your app is already running on production

[prateekbh]

@robinvdvleuten to opt-out of already running sw.js you'll need to add some script to add in your code. pretty trivial