adding flag to disable service worker #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekbh
force-pushed
the
noServiceWorkerFile
branch
from
738c5ce to
c978a03
Compare
reznord
approved these changes
Sep 20, 2017
Member
reznord
left a comment
reznord
left a comment
There was a problem hiding this comment.
LGTM 👍
This PR can be merged once we get the webpack3 in.
developit
reviewed
Sep 20, 2017
| ] | ||
| }) | ||
| }), | ||
| new webpack.DefinePlugin({ |
Member
There was a problem hiding this comment.
I had posted in chat about this but I'll echo here for visibility - does the object form here replace as optimally as this?
new webpack.DefinePlugin({
'process.env.ADD_SW': config.serviceWorker
});
Member
There was a problem hiding this comment.
I believe yargs will have camelCased the flag name at this point.
@prateekbh Have you checked/ran this? This was my thought as well.
prateekbh
force-pushed
the
noServiceWorkerFile
branch
from
c978a03 to
7523fbb
Compare
Member
Author
|
@developit @lukeed it worked for me bothways with and without camel casing |
Member
Author
|
btw made suggested changes, is it ready to merge yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #371