fix: Throw error for unknown command #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wow, thanks a ton @rkostrzewski, this is great! |
developit
reviewed
May 20, 2017
src/commands/create.js
Outdated
| serve: 'preact build && preact serve', | ||
| dev: 'preact watch', | ||
| test: 'eslint src && preact test' | ||
| test: 'eslint src && echo "Error: no test specified" && exit 1' |
Member
There was a problem hiding this comment.
This one we actually probably need to keep as preact test - that command isn't available yet, but it will just spawn a preconfigured jest. I wanted to get the setup into generated package.json's since we can't retroactively update them later.
Would you be all right removing this one line? I think we can get the test command released really soon.
Collaborator
Author
There was a problem hiding this comment.
There will be preact test? ❤️
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currenty runing
preact whateverwon't report error. This is kinda unexpected behaviour and might cause some harm, e.g. in CI environments where script likepreact builtwill return exit code 0.This PR fixes that. I've also took liberty in changing default test script (coz
preact testwon't work now and people might get confused).Pictures coz a picture is worth a thousand words.
Before:
After:
